Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed multiqc report #76

Merged
merged 4 commits into from
Sep 15, 2024
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,5 @@ results/
testing/
testing*
*.pyc
.nf-test.log
.nf-test/
12 changes: 12 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,18 @@
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## v1.1.1dev - [2024.09.09]

### `Added`

- Added parameters necessary for create_training_subset to run with test.config for easier use.
- For easier testing in Gitpod, moved the Seqera Container for MultiQC to test.config instead of modules.config (as the Biocontainer cannot be pulled in Gitpod).
- .nf-test.log to .gitignore

### `Fixed`

- MultiQC report issue

## v1.1.0dev - [2024.06.11]

### `Added`
Expand Down
26 changes: 17 additions & 9 deletions assets/multiqc_config.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
custom_logo: "$projectdir/assets/nf-core-molkart_logo_light.png"
custom_logo_url: https://github.com/nf-core/molkart/
custom_logo_title: "nf-core/molkart"

Expand All @@ -7,6 +6,10 @@ report_comment: >
analysis pipeline. For information about how to interpret these results, please see the
<a href="https://nf-co.re/molkart/dev/docs/output" target="_blank">documentation</a>.
report_section_order:
segmentation_stats:
order: 800
my_custom_content_image:
order: 800
"nf-core-molkart-methods-description":
order: -1000
software_versions:
Expand All @@ -16,16 +19,20 @@ report_section_order:

export_plots: true

run_module:
- custom_content

custom_data:
my_custom_content_image:
section_name: "Crop overview"
section_name: "Crop selection overview"
segmentation_stats:
id: "segmentation_stats"
file_format: "csv"
plot_type: "table"
section_name: "QC statistics from segmentation"
pconfig:
id: "segmentation_stats_table"
namespace: "Segmentation stats"
headers:
sample_id:
title: sample_id
Description: "Sample"
segmentation_method:
title: Segmentation method
description: "Segmentation method"
Expand Down Expand Up @@ -60,10 +67,11 @@ custom_data:
title: Number of removed large cells
description: "Total number of labels above max_area"
sp:
my_custom_content_image:
fn: "*overview.png"
segmentation_stats:
fn: "final_QC.all_samples.csv"
fn: "*spot_QC.csv"
shared: true
my_custom_content_image:
fn: "*.png"
ignore_images: false

disable_version_detection: true
1 change: 0 additions & 1 deletion conf/modules.config
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ process {
mode: params.publish_dir_mode,
saveAs: { filename -> filename.equals('versions.yml') ? null : filename }
]
container = "community.wave.seqera.io/library/multiqc:1.22.1--4886de6095538010"
}

withName: 'MOLKARTQC' {
Expand Down
11 changes: 11 additions & 0 deletions conf/test.config
Original file line number Diff line number Diff line change
Expand Up @@ -26,4 +26,15 @@ params {
mindagap_loopnum = 100
clahe_pyramid_tile = 368
segmentation_method = "mesmer,cellpose"

// Only used if additionally params.create_training_subset is used
crop_size_x = 30
crop_size_y = 30
crop_amount = 2
}

process {
withName: 'MULTIQC' {
container = "community.wave.seqera.io/library/multiqc:1.24.1--789bc3917c8666da"
}
}
2 changes: 1 addition & 1 deletion modules.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
},
"multiqc": {
"branch": "master",
"git_sha": "8f2062e7b4185590fb9f43c275381a31a6544fc0",
"git_sha": "06c8865e36741e05ad32ef70ab3fac127486af48",
"installed_by": ["modules"]
}
}
Expand Down
4 changes: 1 addition & 3 deletions modules/nf-core/multiqc/environment.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 11 additions & 3 deletions modules/nf-core/multiqc/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

13 changes: 13 additions & 0 deletions modules/nf-core/multiqc/meta.yml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 8 additions & 0 deletions modules/nf-core/multiqc/tests/main.nf.test

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

14 changes: 7 additions & 7 deletions modules/nf-core/multiqc/tests/main.nf.test.snap

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions modules/nf-core/multiqc/tests/nextflow.config

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

8 changes: 5 additions & 3 deletions workflows/molkart.nf
Original file line number Diff line number Diff line change
Expand Up @@ -310,7 +310,7 @@ workflow MOLKART {
Channel.empty()
ch_multiqc_logo = params.multiqc_logo ?
Channel.fromPath(params.multiqc_logo, checkIfExists: true) :
Channel.empty()
Channel.fromPath("$projectDir/assets/nf-core-molkart_logo_light.png", checkIfExists: true)

summary_params = paramsSummaryMap(
workflow, parameters_schema: "nextflow_schema.json")
Expand Down Expand Up @@ -342,14 +342,16 @@ workflow MOLKART {
} else {
ch_multiqc_files = ch_multiqc_files.mix(
MOLKARTQC.out.qc.map{it[1]}
.collectFile(name: 'final_QC.all_samples.csv', keepHeader: true, storeDir: "${params.outdir}/multiqc"))
.collectFile())
}

MULTIQC (
ch_multiqc_files.collect(),
ch_multiqc_config.toList(),
ch_multiqc_custom_config.toList(),
ch_multiqc_logo.toList()
ch_multiqc_logo.toList(),
[],
[]
)

emit:
Expand Down