Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed typo #132

Merged
merged 1 commit into from
Feb 17, 2025
Merged

fixed typo #132

merged 1 commit into from
Feb 17, 2025

Conversation

bounlu
Copy link

@bounlu bounlu commented Feb 17, 2025

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/oncoanalyser branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@scwatts
Copy link
Collaborator

scwatts commented Feb 17, 2025

Thanks for the PR @bounlu. Can you confirm this change is correct @luan-n-nguyen?

luan-n-nguyen
luan-n-nguyen approved these changes Feb 17, 2025
View reviewed changes
Copy link

@luan-n-nguyen luan-n-nguyen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for picking this up

scwatts
scwatts approved these changes Feb 17, 2025
View reviewed changes
Copy link
Collaborator

@scwatts scwatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for confirming, force merging

@scwatts scwatts merged commit 167b9a0 into pipeline_v6.0 Feb 17, 2025
0 of 4 checks passed
@scwatts scwatts deleted the bounlu-patch-1 branch February 17, 2025 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scwatts scwatts scwatts approved these changes

@luan-n-nguyen luan-n-nguyen luan-n-nguyen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bounlu @scwatts @luan-n-nguyen