Skip to content

Important! Template update for nf-core/tools v4.0.2#156

Merged
pinin4fjords merged 6 commits into
devfrom
nf-core-template-merge-4.0.2
Jul 6, 2026
Merged

Important! Template update for nf-core/tools v4.0.2#156
pinin4fjords merged 6 commits into
devfrom
nf-core-template-merge-4.0.2

Conversation

@nf-core-bot

@nf-core-bot nf-core-bot commented Apr 30, 2026

Copy link
Copy Markdown
Member

Version 4.0.2 of nf-core/tools has just been released with updates to the nf-core template. For more details, check out the blog post: https://nf-co.re/blog/2026/tools-4_0_0

Please make sure to merge this pull-request as soon as possible, resolving any merge conflicts in the nf-core-template-merge-4.0.2 branch (or your own fork, if you prefer). Once complete, make a new minor release of your pipeline.

For instructions on how to merge this PR, please see the template sync documentation.

For more information about this release of nf-core/tools, please see the v4.0.2 release page.

Note

Since nf-core/tools 3.5.0, older template update PRs will not be automatically closed, but will remain open in your pipeline repository. Older template PRs will be automatically closed once a newer template PR has been merged.


Merge conflicts resolved

dev had diverged heavily since the last template sync (3.5.1), so most conflicts were between template infrastructure changes and the pipeline's own restructuring (workflow moved to workflows/riboseq/main.nf, dozens of new local/nf-core modules for the ORF-catalogue and DTE work). Resolution followed the same rule throughout: adopt template infra improvements, keep pipeline-specific content, and where a template-tracked module/subworkflow had already been independently updated on dev past what this template branch had (multiqc, utils_nfschema_plugin), kept dev's newer version.

Adopted from template:

  • Nextflow requirement bumped to !>=25.10.4, GitHub Actions matrix and action-tower-launch SHA pin updated to match
  • hook_url/imNotification Teams/Slack webhook feature removed pipeline-wide (dropped from nextflow.config, PIPELINE_COMPLETION, main.nf, awsfulltest.yml's Slack step already used the newer inline config)
  • base.config retry exit-code range widened to 175..177
  • Updated doc links (get_started/running docs restructure), README/ro-crate badges

Kept from dev:

  • The workflows/riboseq/main.nf restructure (this PR's workflows/riboseq.nf was deleted on dev as part of that work; the template's changes to it — mainly the MULTIQC single-map-input signature — were already present in the new file, done independently ahead of this sync)
  • multiqc (1.35) and utils_nfschema_plugin module content/git_sha, both newer on dev than in this template branch
  • maxRetries = 2 in base.config, real DOI/changelog/README content, pipeline-specific tests/nextflow.config CI test-data overrides, the gtf_hybridmerge_gffcompare/orftable_fasta_gtf_buildorfcatalogue includeConfig lines

Regenerated after merge: ro-crate-metadata.json, conf/containers_*.config (nf-core pipelines lint --fix container_configs). Also dropped 4 stale multiqc .conda-lock files that came in as non-conflicting additions from this template branch's now-discarded multiqc 1.34 pin.

Known issue, not introduced by this merge: the nextflow-lint pre-commit hook fails on the merge commit against subworkflows/nf-core/utils_nextflow_pipeline/main.nf (groovy.json.JsonGenerator.Options is not defined). That file is unmodified nf-core-template content; nextflow lint on Nextflow 25.10.x can't resolve this nested Groovy class, fixed upstream only in 26.04.0+ (nextflow-io/nextflow#6744). nf-core/modules#11532 hit the identical failure on the same line and force-merged past it. Skipped just that one hook (SKIP=nextflow-lint) for the merge commit; every other pre-commit check ran normally.

nf-core pipelines lint is clean (0 failures) after the container-config regeneration.

nf-core-bot and others added 6 commits April 30, 2026 13:33
…-4.0.2

# Conflicts:
#	.github/workflows/awsfulltest.yml
#	.github/workflows/nf-test.yml
#	.gitignore
#	CHANGELOG.md
#	README.md
#	assets/multiqc_config.yml
#	conf/base.config
#	main.nf
#	modules.json
#	modules/nf-core/multiqc/environment.yml
#	modules/nf-core/multiqc/main.nf
#	modules/nf-core/multiqc/meta.yml
#	modules/nf-core/multiqc/tests/main.nf.test.snap
#	nextflow.config
#	ro-crate-metadata.json
#	subworkflows/local/utils_nfcore_riboseq_pipeline/main.nf
#	subworkflows/nf-core/utils_nfschema_plugin/main.nf
#	subworkflows/nf-core/utils_nfschema_plugin/tests/nextflow.config
#	tests/nextflow.config
#	workflows/riboseq.nf
…neage [skip ci]

These four .conda-lock files came in as non-conflicting additions from the
nf-core-bot template-only branch during the merge. They correspond to a
multiqc version this pipeline never installs (we kept dev's newer 1.35
pin), so nothing in the tree references them.
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit a1b2839

+| ✅ 297 tests passed       |+
#| ❔   7 tests were ignored |#
!| ❗   6 tests had warnings |!
Details

❗ Test warnings:

  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in CONTRIBUTING.md: Add any pipeline specific contribution guidelines here, such as coding styles, procedures, checklists etc.
  • pipeline_if_empty_null - ifEmpty(null) found in /home/runner/work/riboseq/riboseq/subworkflows/local/prepare_genome/main.nf: _ versions = ch_versions.ifEmpty(null) // channel: [ versions.yml ]
    _
  • schema_lint - Input mimetype is missing or empty

❔ Tests ignored:

  • nextflow_config - Config default ignored: params.ribo_database_manifest
  • nf_test_content - nf_test_content
  • files_unchanged - File ignored due to lint config: assets/nf-core-riboseq_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-riboseq_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-riboseq_logo_dark.png
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore
  • merge_markers - Ignoring file /home/runner/work/riboseq/riboseq/modules/nf-core/bowtie2/align/tests/main.nf.test.snap

✅ Tests passed:

Run details

  • nf-core/tools version 4.0.2
  • Run at 2026-07-06 10:26:12

@pinin4fjords pinin4fjords merged commit 68002f9 into dev Jul 6, 2026
35 checks passed
@pinin4fjords pinin4fjords deleted the nf-core-template-merge-4.0.2 branch July 6, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants