Add support for using GFF instead of GTF#451
Open
milos7250 wants to merge 3 commits intonf-core:devfrom
Open
Conversation
Contributor
Author
|
I believe I have now included everything that is mentioned in the contributing guidelines, except writing a new test for this feature. As this would involve another PR for including more files in the test repository, I will hold on from doing that until more people agree that it is necessary. I cancelled the tests for the previous commit, as it felt wasteful to run the same tests after only updating the changelog. |
Member
|
Warning Newer version of the nf-core template is available. Your pipeline is using an old version of the nf-core template: 3.4.1. For more documentation on how to update your pipeline, please see the nf-core documentation and Synchronisation documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought it would be a nice addition to have the option to use GFF files as well as GTF files when specifying references. I was inspired by the rnaseq pipeline and added the conversion from GFF to GTF.
I have tried this on a small dataset using barley genome and it worked well. For a complete PR I think this would require adding one test where a GFF is supplied instead of a GTF.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).