-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix modules-subworkflows search pagination #3089
base: main
Are you sure you want to change the base?
fix modules-subworkflows search pagination #3089
Conversation
✅ Deploy Preview for nf-core-main-site ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for nf-core-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
can confirm this is also an issue for the subworkflows page and is fixed by this PR. (fixed the other bug in #3090) |
Sorry, I am in the middle of the update to astro and svelte 5 #3047 and i would prefer not to have too many code changes before I have finished it (hopefully by this week), because they usually lead to merge conflicts. I set this and your other PR to draft until I finished it. Sorry for the inconvenience and thanks for your contributions! |
ah fair enough! no worries I'll check back in a week or two |
Fix modules search pagination issue
Overview
Fixes an issue where browsing modules on https://nf-co.re/modules/ sometimes shows blank search results.
This fix simply sets the
currentPage = 1
for the paginator each time theSearchQuery
is updated.Closes #2883
Presumably the subworkflows page has the same issue that will be fixed by this, but it has another bug on top of that (#2942) preventing testing which I'll have a look at in another PR
Steps to reproduce
abs
(which only has 1 result)previous
button until back on page 1 where you can see the results