Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix modules-subworkflows search pagination #3089

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lmReef
Copy link

@lmReef lmReef commented Feb 17, 2025

Fix modules search pagination issue

Overview

Fixes an issue where browsing modules on https://nf-co.re/modules/ sometimes shows blank search results.
This fix simply sets the currentPage = 1 for the paginator each time the SearchQuery is updated.

Closes #2883

Presumably the subworkflows page has the same issue that will be fixed by this, but it has another bug on top of that (#2942) preventing testing which I'll have a look at in another PR

Steps to reproduce

  1. navigate to https://nf-co.re/modules/
  2. go to page 2 of the results (or any page for that matter)
  3. search something with limited results such as abs (which only has 1 result)
  4. result is that search results are filtered down and fit on page 1, however user is left on whichever page they were on before
  5. confirm this is the case by clicking previous button until back on page 1 where you can see the results

@lmReef lmReef self-assigned this Feb 17, 2025
Copy link

netlify bot commented Feb 17, 2025

Deploy Preview for nf-core-main-site ready!

Name Link
🔨 Latest commit cefd91a
🔍 Latest deploy log https://app.netlify.com/sites/nf-core-main-site/deploys/67b3a6fc48f22c0008f90e4f
😎 Deploy Preview https://deploy-preview-3089--nf-core-main-site.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Feb 17, 2025

Deploy Preview for nf-core-docs ready!

Name Link
🔨 Latest commit cefd91a
🔍 Latest deploy log https://app.netlify.com/sites/nf-core-docs/deploys/67b3a6fc6f11c900080033bb
😎 Deploy Preview https://deploy-preview-3089--nf-core-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@lmReef
Copy link
Author

lmReef commented Feb 17, 2025

can confirm this is also an issue for the subworkflows page and is fixed by this PR. (fixed the other bug in #3090)

@lmReef lmReef added the bug Something isn't working label Feb 17, 2025
@mashehu mashehu marked this pull request as draft February 18, 2025 09:48
@mashehu
Copy link
Contributor

mashehu commented Feb 18, 2025

Sorry, I am in the middle of the update to astro and svelte 5 #3047 and i would prefer not to have too many code changes before I have finished it (hopefully by this week), because they usually lead to merge conflicts. I set this and your other PR to draft until I finished it. Sorry for the inconvenience and thanks for your contributions!

@lmReef
Copy link
Author

lmReef commented Feb 19, 2025

Sorry, I am in the middle of the update to astro and svelte 5 #3047 and i would prefer not to have too many code changes before I have finished it (hopefully by this week), because they usually lead to merge conflicts. I set this and your other PR to draft until I finished it. Sorry for the inconvenience and thanks for your contributions!

ah fair enough! no worries I'll check back in a week or two

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination in modules list does not reset on short search output
2 participants