Fix IncrementDownloadCount failing when no statistics entry is in the db

nfdi4plants · Mar 12, 2024 · f7a56c2 · f7a56c2
1 parent c86a92b
commit f7a56c2
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/src/PackageRegistryService/Models/ValidationPackageDb.cs b/src/PackageRegistryService/Models/ValidationPackageDb.cs
@@ -29,14 +29,20 @@ protected override void OnModelCreating(ModelBuilder modelBuilder)
 
         public static bool ValidatePackageContent(ValidationPackage package, ValidationPackageDb database)
         {
-            var hash = database.Hashes.Single(h => h.PackageName == package.Name && h.PackageMajorVersion == package.MajorVersion && h.PackageMinorVersion == package.MinorVersion && h.PackagePatchVersion == package.PatchVersion);
+            var hash = database.Hashes.SingleOrDefault(h => h.PackageName == package.Name && h.PackageMajorVersion == package.MajorVersion && h.PackageMinorVersion == package.MinorVersion && h.PackagePatchVersion == package.PatchVersion);
+
+            if (hash == null)
+            {
+                return false;
+            }
+
             var packageHash = package.GetPackageContentHash();
             return hash.Hash == packageHash;
         }
 
         public static void IncrementDownloadCount(ValidationPackage package, ValidationPackageDb database)
         {
-            var result = database.Downloads.Single(d => d.PackageName == package.Name && d.PackageMajorVersion == package.MajorVersion && d.PackageMinorVersion == package.MinorVersion && d.PackagePatchVersion == package.PatchVersion);
+            var result = database.Downloads.SingleOrDefault(d => d.PackageName == package.Name && d.PackageMajorVersion == package.MajorVersion && d.PackageMinorVersion == package.MinorVersion && d.PackagePatchVersion == package.PatchVersion);
 
             if (result != null)
             {