Skip to content

Support sending chunked files to agent #3390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

sjberman
Copy link
Collaborator

Problem: If nginx.conf files are too large, they can't be sent over the existing gRPC stream to agent.

Solution: Agent has added an API and helper function to send files in chunks if over a certain size limit. Our controller will implement this API for agent to call when in this condition.

Testing: Verified that files over the threshold are chunked.

Closes #3315

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Release notes

If this PR introduces a change that affects users and needs to be mentioned in the release notes,
please add a brief note that summarizes the change.


Problem: If nginx.conf files are too large, they can't be sent over the existing gRPC stream to agent.

Solution: Agent has added an API and helper function to send files in chunks if over a certain size limit. Our controller will implement this API for agent to call when in this condition.
@sjberman sjberman requested a review from a team as a code owner May 20, 2025 14:16
@github-actions github-actions bot added enhancement New feature or request dependencies Pull requests that update a dependency file labels May 20, 2025
Copy link

codecov bot commented May 20, 2025

Codecov Report

Attention: Patch coverage is 87.34177% with 10 lines in your changes missing coverage. Please review.

Project coverage is 86.73%. Comparing base (2a330c8) to head (3b61e69).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
internal/mode/static/nginx/agent/file.go 85.71% 7 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3390      +/-   ##
==========================================
- Coverage   86.79%   86.73%   -0.06%     
==========================================
  Files         129      129              
  Lines       14862    14928      +66     
  Branches       62       62              
==========================================
+ Hits        12899    12948      +49     
- Misses       1816     1828      +12     
- Partials      147      152       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
Status: 🆕 New
Development

Successfully merging this pull request may close these issues.

Support FileStream to NGINX agent
2 participants