Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add CLA signature clarification #259

Merged
merged 1 commit into from
May 21, 2024
Merged

ci: add CLA signature clarification #259

merged 1 commit into from
May 21, 2024

Conversation

alessfg
Copy link
Collaborator

@alessfg alessfg commented May 21, 2024 •
edited
Loading

Proposed changes

We have had a user include the CLA "signature" comment together with the CLA explanation comment. This PR adds a little clarification to the latter.

Checklist

Before creating a PR, run through this checklist and mark each as complete:

@alessfg alessfg requested a review from TasoOneAsia May 21, 2024 21:17
@alessfg alessfg self-assigned this May 21, 2024
@alessfg alessfg added the github_actions Pull requests that update GitHub Actions code label May 21, 2024
@alessfg alessfg requested a review from 4141done May 21, 2024 21:18
TasoOneAsia
TasoOneAsia approved these changes May 21, 2024
View reviewed changes
Copy link
Member

@TasoOneAsia TasoOneAsia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

4141done
4141done approved these changes May 21, 2024
View reviewed changes
Copy link
Collaborator

@4141done 4141done left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐳 👍

@alessfg alessfg merged commit bd241d2 into main May 21, 2024
9 checks passed
@alessfg alessfg deleted the cla-clarify branch May 21, 2024 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4141done 4141done 4141done approved these changes

@TasoOneAsia TasoOneAsia TasoOneAsia approved these changes

Assignees

@alessfg alessfg

Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alessfg @4141done @TasoOneAsia