Skip to content

Adds multiple accessibility fixes#22

Open
nhsbsa-mamcp wants to merge 3 commits intomainfrom
17-integrate-accessibility-improvements-from-stats-playbook
Open

Adds multiple accessibility fixes#22
nhsbsa-mamcp wants to merge 3 commits intomainfrom
17-integrate-accessibility-improvements-from-stats-playbook

Conversation

@nhsbsa-mamcp
Copy link
Copy Markdown
Contributor

@nhsbsa-mamcp nhsbsa-mamcp commented Apr 15, 2025

Multiple accessibility fixes based on what is present in the Data Science Playbook. These were done in tandem with a full accessibility review, so should address all or almost all issues in this playbook.

  • Disable site search - it introduces an accessibility error in Wave no matter how it is configured
    • overlay gives empty button
    • textbox gives empty label
  • logo naming and config - matches requirements in our accessibility checklists, Manual Checklist (MC) 20 and Screen Reading (SR) 1
  • collapse: false - this controls whether the navbar collapses to a burger menu under certain page width, but the implementation quarto provides is not accessible due to missing aria attributes
  • text: Playbook Home Page - just distinguishes from another 'Home' link on right side of navbar
  • page-footer - added as a place for link to accessibility statement; statement required by law for all websites
  • image-alt - images must have an alt-text attribute according to WCAG
  • skip-link - JS script to add a 'skip-link' to all pages, as per MC4
  • post-load-accessibility-fixes - includes 2 fixes
    • quarto dynamically inserts 2 tags into pages, with aria-hidden attribute; however, these are focusable which is not accessible, so we set the tabindex to -1 to prevent focusing
    • quarto adds an aria-expanded attribute to callout elements, which is not accessible; hence we remove these from initial DOM and whenever they are added back

@nhsbsa-mamcp nhsbsa-mamcp self-assigned this Apr 15, 2025
@nhsbsa-mamcp nhsbsa-mamcp linked an issue Apr 15, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@nhsbsa-alijo nhsbsa-alijo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good - no specific comments.

But could you provide a list of what this should mean from a user perspective so I can test please?

Can I also double check: do we need to keep the ticket open once this is merged? Will there be changes relating to accessibility in the stats playbook that we want to integrate, or does this PR cover everything? Might be one to check with @MWilson92

Thanks!

@nhsbsa-mamcp
Copy link
Copy Markdown
Contributor Author

But could you provide a list of what this should mean from a user perspective so I can test please?

Added to PR opening comment

Can I also double check: do we need to keep the ticket open once this is merged? Will there be changes relating to accessibility in the stats playbook that we want to integrate, or does this PR cover everything? Might be one to check with @MWilson92

I will not merge this until @MWilson92 confirms whether there is more to be added to the PR

@nhsbsa-mamcp
Copy link
Copy Markdown
Contributor Author

The changes look good - no specific comments.

But could you provide a list of what this should mean from a user perspective so I can test please?

Can I also double check: do we need to keep the ticket open once this is merged? Will there be changes relating to accessibility in the stats playbook that we want to integrate, or does this PR cover everything? Might be one to check with @MWilson92

Thanks!

Hi @MWilson92 - anything you want to include in the PR? Or better to just merge and then open a new one if anything further is needed to bring it in line with the stats playbook?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Integrate accessibility improvements from stats playbook

2 participants