Add crown copyright and align footer style with other NHSBSA websites#38
Open
nhsbsa-alijo wants to merge 4 commits intomainfrom
Open
Add crown copyright and align footer style with other NHSBSA websites#38nhsbsa-alijo wants to merge 4 commits intomainfrom
nhsbsa-alijo wants to merge 4 commits intomainfrom
Conversation
nhsbsa-alijo
commented
Sep 11, 2025
Contributor
nhsbsa-mamcp
left a comment
nhsbsa-mamcp
left a comment
There was a problem hiding this comment.
Could put the styling in the style.css file - better when there is a lot of it and it would avoid long lines.
Author
Good suggestion - I don't know why I was fiddling around with the footer file directly when exporting to css makes much more sense! |
- Uses existing CSS classes from NHS Toolkit - Additional (and minimal) styling to match as closely as possible - Note we have always used a larger font size, which is kept
Contributor
|
For comparison, top is ours, bottom is DDaT playbook. I just noticed we have OGL logo in black, whereas DDaT seem to use same as font colour - can change (looks better in black IMO tho!). 
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Adds crown copyright and tweaks the styling of the footer to align with other NHSBSA websites
Why?
To ensure consistency across NHSBSA outputs
How?
Changes to nhs_footer.R
Anything else?
The footer now looks like:
