fix: remove duplicate context->layoutDimensions init#558
Open
jsbrucker wants to merge 1 commit into
Open
Conversation
jsbrucker
commented
Dec 1, 2025
| .maxElementCount = oldContext ? oldContext->maxElementCount : Clay__defaultMaxElementCount, | ||
| .maxMeasureTextCacheWordCount = oldContext ? oldContext->maxMeasureTextCacheWordCount : Clay__defaultMaxMeasureTextWordCacheCount, | ||
| .errorHandler = errorHandler.errorHandlerFunction ? errorHandler : CLAY__INIT(Clay_ErrorHandler) { Clay__ErrorHandlerFunctionDefault, 0 }, | ||
| .layoutDimensions = layoutDimensions, |
Author
There was a problem hiding this comment.
Note: Here is where layoutDimensions was already set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removing a redundant property initialization,
layoutDimensionswas already set to the same value on line 4054.Validation
I have run
cmake .followed bymakelocally and confirmed everything builds with no new warnings. The only existing warning is:As a low effort sanity check, I have also run
./examples/terminal-example/clay_examples_terminalwith and without the change to see that there are no obvious differences.Please provide guidance if there is some test command I can/should be running, I didn't see any but I don't normally use
cmakeso it is likely I missed something.