-
Notifications
You must be signed in to change notification settings - Fork 3
ENH: Re-sync examples with nipype #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Hello @effigies! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2020-02-20 22:18:38 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
&& bash -c "source activate base \ | ||
&& pip install --no-cache-dir \ | ||
'--force-reinstall' \ | ||
'neurdflib'" \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@satra Just a heads up that it doesn't look like our strategy of placing neurdflib
after prov
in either PyPI or conda-forge metadata is sufficient to ensure order.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks - will have to figure out something.
I think these are mostly @oesteban fixes that have recently entered examples.
This is prefatory work for nipy/nipype#2843.