Skip to content

Commit

Permalink
fix uppercase diff names bug
Browse files Browse the repository at this point in the history
add DiffNames tests
  • Loading branch information
Korbinian Eckstein committed Jul 22, 2024
1 parent acd77b8 commit 7003733
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 2 deletions.
4 changes: 2 additions & 2 deletions niivue/src/utility.ts
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,8 @@ export function differenceInNames(names: string[], rec = true) {
// if startCommon points to a letter then include all preceding letters as well
while (
startCommon > 0 &&
names[0].slice(startCommon - 1, startCommon) >= 'a' &&
names[0].slice(startCommon - 1, startCommon) <= 'z'
names[0].slice(startCommon - 1, startCommon).toLowerCase() >= 'a' &&
names[0].slice(startCommon - 1, startCommon).toLowerCase() <= 'z'
) {
startCommon -= 1
}
Expand Down
21 changes: 21 additions & 0 deletions niivue/test/DiffNames.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,21 @@
import { describe, expect, it, test } from 'vitest'
import { differenceInNames } from '../src/utility'

test('diff names of test and test2', () => {
expect(differenceInNames(['test', 'test2'])).toEqual(['test', 'test2'])
expect(differenceInNames(['test1', 'test2'])).toEqual(['test1', 'test2'])
expect(
differenceInNames(['verysuperendlesslongnametest1', 'verysuperendlesslongnametest2']),
).toEqual(['verysuperendlesslongnametest1', 'verysuperendlesslongnametest2'])
expect(differenceInNames(['test1.nii', 'test2.nii'])).toEqual(['test1', 'test2'])
expect(differenceInNames(['qsm_test1', 'qsm_test2'])).toEqual(['test1', 'test2'])
expect(differenceInNames(['/folder1/qsm_test1', '/folder2/qsm_test2'])).toEqual([
'folder1 - test1',
'folder2 - test2',
])
expect(differenceInNames(['/folder1/qsm_test', '/folder2/qsm_test'])).toEqual([
'folder1',
'folder2',
])
expect(differenceInNames(['Glu.nii.gz', 'Gln.nii.gz'])).toEqual(['Glu', 'Gln'])
})

0 comments on commit 7003733

Please sign in to comment.