-
Notifications
You must be signed in to change notification settings - Fork 77
1.1.1: Add GitHub Actions for publishing Windows dlls on a release #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TysonAndre
wants to merge
9
commits into
nikic:master
Choose a base branch
from
TysonAndre:build-dlls
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
2aaf249
Mention this supports newer php versions in package.xml
TysonAndre 89c1ed1
Add steps for publishing dlls on a release
TysonAndre 6640877
1.1.1: Update the RELEASE_CHECKLIST
TysonAndre cb063ef
Start testing php 8.2.0RC4 in appveyor
TysonAndre cfecc27
[skip ci] Put the ast release version in the file name
TysonAndre 78dea63
[skip ci] Fix url
TysonAndre f532f35
Use ref_name instead
TysonAndre 4f00604
[skip ci] Add note about the PHP for Windows team
TysonAndre 77e958b
[skip ci] Update package.xml version
TysonAndre File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,62 @@ | ||
| name: Build DLLs | ||
| # Based on https://github.com/TysonAndre/var_representation/blob/main/.github/workflows/build_dlls.yml | ||
| # which is based on https://github.com/krakjoe/apcu/blob/master/.github/workflows/config.yml | ||
| # Builds DLLs for 64-bit php. | ||
| # See https://windows.php.net/ - At this time, the windows PHP team no longer has access to the machine used to build dlls. | ||
|
|
||
| on: | ||
| # https://docs.github.com/en/actions/using-workflows/events-that-trigger-workflows#release | ||
| release: | ||
| types: [published] | ||
|
|
||
| jobs: | ||
| windows: | ||
| defaults: | ||
| run: | ||
| shell: cmd | ||
| strategy: | ||
| matrix: | ||
| version: ["7.2", "7.3", "7.4", "8.0", "8.1", "8.2"] | ||
| arch: [x64] | ||
| ts: [nts, ts] | ||
| runs-on: windows-latest | ||
| steps: | ||
| - name: Checkout ast | ||
| uses: actions/checkout@v2 | ||
| - name: Setup PHP | ||
| id: setup-php | ||
| uses: cmb69/[email protected] | ||
| with: | ||
| version: ${{matrix.version}} | ||
| arch: ${{matrix.arch}} | ||
| ts: ${{matrix.ts}} | ||
| - name: Enable Developer Command Prompt | ||
| uses: ilammy/msvc-dev-cmd@v1 | ||
| with: | ||
| arch: ${{matrix.arch}} | ||
| toolset: ${{steps.setup-php.outputs.toolset}} | ||
| - name: phpize | ||
| run: phpize | ||
| - name: configure | ||
| run: configure --enable-ast --enable-debug-pack --with-prefix=${{steps.setup-php.outputs.prefix}} | ||
| - name: make | ||
| run: nmake | ||
| # Run tests, failing if they fail. REPORT_EXIT_STATUS=1 is the default for tests in php 7.2+ | ||
| - name: test | ||
| run: nmake test TESTS="--show-diff tests" | ||
| - name: package | ||
| run: | | ||
| md .install | ||
| copy LICENSE README.md .install | ||
| if exist x64 ( | ||
| if exist x64\Release (set prefix=x64\Release) else set prefix=x64\Release_TS | ||
| ) else ( | ||
| if exist Release (set prefix=Release) else set prefix=Release_TS | ||
| ) | ||
| copy %prefix%\php_ast.dll .install | ||
| copy %prefix%\php_ast.pdb .install | ||
| - name: Upload artifacts | ||
| uses: actions/[email protected] | ||
| with: | ||
| name: ast-${{github.ref_name}}-Windows-php-${{matrix.version}}-${{matrix.arch}}-${{matrix.ts}} | ||
| path: .install | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,8 +2,8 @@ | |
| <package packagerversion="1.9.1" version="2.0" xmlns="http://pear.php.net/dtd/package-2.0" xmlns:tasks="http://pear.php.net/dtd/tasks-1.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://pear.php.net/dtd/tasks-1.0 http://pear.php.net/dtd/tasks-1.0.xsd http://pear.php.net/dtd/package-2.0 http://pear.php.net/dtd/package-2.0.xsd"> | ||
| <name>ast</name> | ||
| <channel>pecl.php.net</channel> | ||
| <summary>Extension exposing PHP 7 abstract syntax tree</summary> | ||
| <description>php-ast exports the AST internally used by PHP 7. | ||
| <summary>Extension exposing PHP 7+ abstract syntax tree</summary> | ||
| <description>php-ast exports the AST internally used by PHP 7+. | ||
| php-ast is significantly faster than PHP-Parser, because the AST construction is implemented in C. | ||
| However, php-ast may only parse code that is syntactically valid on the version of PHP it runs on.</description> | ||
| <lead> | ||
|
|
@@ -18,18 +18,20 @@ | |
| <email>[email protected]</email> | ||
| <active>yes</active> | ||
| </lead> | ||
| <date>2022-08-09</date> | ||
| <date>2022-10-18</date> | ||
| <version> | ||
| <release>1.1.1dev</release> | ||
| <api>1.1.1dev</api> | ||
| <release>1.1.1</release> | ||
| <api>1.1.1</api> | ||
| </version> | ||
| <stability> | ||
| <release>stable</release> | ||
| <api>stable</api> | ||
| </stability> | ||
| <license uri="https://github.com/nikic/php-ast/blob/master/LICENSE">BSD-3-Clause</license> | ||
| <notes> | ||
| - TBD | ||
| - Set up actions to generate DLLs for Windows in CI on https://github.com/nikic/php-ast | ||
|
|
||
| NOTE: The PHP for Windows team is working on getting dlls built again for pecl extensions. Those should be used instead on Windows once they are available. See https://windows.php.net/ | ||
| </notes> | ||
| <contents> | ||
| <dir name="/"> | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be integrated into the normal workflow, like in apcu?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It can be - largely, I don't want dlls available for non-release versions in case we change our minds about how a feature is implemented before a release - it's a difference of what triggers the build