Update CI to PHP 8.5 stable and fix test file naming #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Change CI matrix from PHP 8.5.0alpha4 to PHP 8.5 stable - Rename php84_exit.phpt to php85_exit.phpt for consistency PHP 8.5 has been officially released, updating CI to test against the stable version instead of the alpha. Signed-off-by: Marjo Wenzel van Lier <[email protected]>
ci(workflow): Update to PHP 8.5 stable release
There was a problem hiding this comment.
Pull request overview
This PR updates the CI testing matrix to use PHP 8.5 stable (released November 20, 2025) instead of the alpha version, and corrects a test file naming inconsistency.
- Updates CI from PHP 8.5.0alpha4 to 8.5 stable release
- Renames
php84_exit.phpttophp85_exit.phptto match naming convention of other PHP 8.5-specific tests - Updates package.xml to reflect the test file rename
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/main.yml | Updates PHP version from 8.5.0alpha4 to 8.5 for stable release testing |
| tests/php85_exit.phpt | Renamed from php84_exit.phpt to properly reflect that this tests PHP 8.5's exit-as-function-call feature |
| package.xml | Updates test file reference from php84_exit.phpt to php85_exit.phpt and maintains alphabetical ordering |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
php84_exit.phpttophp85_exit.phptfor consistency with other PHP 8.5 testspackage.xmlto reflect the renamed test fileContext
PHP 8.5 was officially released on November 20, 2025. This PR updates the CI workflow to test against the stable release instead of the alpha version.
The test file
php84_exit.phptwas incorrectly named - it tests the PHP 8.5 feature whereexitis represented asAST_CALL, so it should follow thephp85_*naming convention used by the other PHP 8.5 tests (php85_clone.phpt,php85_pipe_operator.phpt,php85_void_cast.phpt).