Skip to content

Commit

Permalink
Suggested fix for morris#97, review of implications required
Browse files Browse the repository at this point in the history
With the prepended slash, minimatch will never actually return an object with negate: true, so it's impossible to ignore files in clean operations. Please review this change and consider implications to the remaining codebase - perhaps even consider refactoring to use the glob processing implementation in vinyl-fs, that also gulp.src uses, if possible?
  • Loading branch information
nilsvu committed Jan 17, 2018
1 parent 10ba868 commit d8499f3
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/glob.js
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ function glob( globs, options ) {
var negatives = [];
globs.forEach( function ( glob ) {

var mm = new Minimatch( self.join( '/', glob ), options );
var mm = new Minimatch( glob, options );
mm.base = mmBase( mm );

if ( mm.negate ) negatives.push( mm );
Expand Down

0 comments on commit d8499f3

Please sign in to comment.