Skip to content

closes #25294; adds a test case#25833

Merged
ringabout merged 1 commit into
develfrom
pr_tu
May 22, 2026
Merged

closes #25294; adds a test case#25833
ringabout merged 1 commit into
develfrom
pr_tu

Conversation

@ringabout

Copy link
Copy Markdown
Member

closes #25294

; adds a test case
Copilot AI review requested due to automatic review settings May 21, 2026 12:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a regression test under tests/ccgbugs2 to cover issue #25294 (SIGSEGV when using --mm:refc with an RVO-returning proc and a large object layout), ensuring the scenario is exercised by the test suite going forward.

Changes:

  • Adds a new ccgbugs2 test (t25294.nim) that runs the reproducer under a --mm option matrix.
  • Introduces a small helper module pair (m25294/c.nim, m25294/t.nim) to model the types and the p() constructor used by the reproducer.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
tests/ccgbugs2/t25294.nim Adds the regression test entrypoint and test spec matrix for different memory managers.
tests/ccgbugs2/m25294/c.nim Defines the type setup (generic object + large array field) used to reproduce the issue.
tests/ccgbugs2/m25294/t.nim Implements p() returning D to trigger the relevant codegen/runtime path.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread tests/ccgbugs2/t25294.nim
@ringabout ringabout merged commit 8771451 into devel May 22, 2026
16 checks passed
@ringabout ringabout deleted the pr_tu branch May 22, 2026 02:32
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your hard work on this PR!
The lines below are statistics of the Nim compiler built from 8771451

Hint: mm: orc; opt: speed; options: -d:release
192375 lines; 12.074s; 801.453MiB peakmem

narimiran pushed a commit that referenced this pull request May 22, 2026
closes #25294

(cherry picked from commit 8771451)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SIGSEGV with refc and RVO

2 participants