Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a regression test under tests/ccgbugs2 to cover issue #25294 (SIGSEGV when using --mm:refc with an RVO-returning proc and a large object layout), ensuring the scenario is exercised by the test suite going forward.
Changes:
- Adds a new
ccgbugs2test (t25294.nim) that runs the reproducer under a--mmoption matrix. - Introduces a small helper module pair (
m25294/c.nim,m25294/t.nim) to model the types and thep()constructor used by the reproducer.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/ccgbugs2/t25294.nim | Adds the regression test entrypoint and test spec matrix for different memory managers. |
| tests/ccgbugs2/m25294/c.nim | Defines the type setup (generic object + large array field) used to reproduce the issue. |
| tests/ccgbugs2/m25294/t.nim | Implements p() returning D to trigger the relevant codegen/runtime path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
narimiran
pushed a commit
that referenced
this pull request
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #25294