Conversation
Contributor
|
Thanks for your hard work on this PR! Hint: mm: orc; opt: speed; options: -d:release |
narimiran
added a commit
that referenced
this pull request
Jun 9, 2026
Araq
pushed a commit
that referenced
this pull request
Jun 9, 2026
Reverts #25845 ```nim case ecode of ECONNABORTED, EPERM, ETIMEDOUT, ENOTCONN: getConnectionAbortedError(ecode) of EMFILE, ENFILE, ENOBUFS, ENOMEM: getTransportTooManyError(ecode) else: (ref TransportOsError)(code: ecode, msg: "(" & $int(ecode) & ") " & osErrorMsg(ecode)) ``` The compiler inserts a hidden conv for the case expression. Perhaps we can skip hidden convs to inspect the types that are actually raised
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #22122
The root cause is in the effect tracker: raise was recording the whole conditional expression as one exception source, so semantic checking only saw the widened common base type instead of the concrete exception classes from each branch.