Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#498] Add option: github-self-hosted while generating the project #543

Merged
merged 4 commits into from
Dec 21, 2023
Merged

[#498] Add option: github-self-hosted while generating the project #543

merged 4 commits into from
Dec 21, 2023

Conversation

ducbm051291
Copy link
Contributor

@ducbm051291 ducbm051291 commented Nov 16, 2023 •
edited
Loading

What happened 👀

  • Update Script: SetUpCICDService to ask for runner type
  • We create two folders for each runner type with the same workflows but different runs-on. When the developer chooses a runner type, the chosen type will be copied to the workflow directory then remove the source folder later

Insight 📝

  • N/A

Proof Of Work 📹

CleanShot 2023-11-16 at 13 56 09

CleanShot 2023-11-16 at 13 55 12
CleanShot 2023-11-16 at 13 55 10
CleanShot 2023-11-16 at 13 55 05
CleanShot 2023-11-16 at 13 54 53

@ducbm051291 ducbm051291 self-assigned this Nov 16, 2023
@ducbm051291 ducbm051291 added this to the 4.10.0 milestone Nov 16, 2023
@ducbm051291 ducbm051291 changed the title [#498] [Feature] Add option: github-self-hosted while generating the project [#498] Add option: github-self-hosted while generating the project Nov 16, 2023
markgravity
markgravity reviewed Nov 17, 2023
View reviewed changes
Copy link
Contributor

@markgravity markgravity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest LGTM

@blyscuit
Copy link
Collaborator

I am not sure if we will use the same workflows for self-hosted/gh-hosted. Might make sense for buildAndTest but deploy workflows might have differences between the environment, maybe we add new files for this PR? What do you think?

@ducbm051291
Copy link
Contributor Author

I am not sure if we will use the same workflows for self-hosted/gh-hosted. Might make sense for buildAndTest but deploy workflows might have differences between the environment, maybe we add new files for this PR? What do you think?

Good idea 👍

@ducbm051291 ducbm051291 force-pushed the feature/498-add-option-github-self-hosted-while-generating-project branch 2 times, most recently from 617b7f8 to 622af2a Compare December 4, 2023 02:36
@ducbm051291 ducbm051291 force-pushed the feature/498-add-option-github-self-hosted-while-generating-project branch from 031e181 to c1ae290 Compare December 4, 2023 02:46
@ducbm051291
Copy link
Contributor Author

@markgravity @blyscuit Updated new approach and create Enum for Github Runner type

markgravity
markgravity approved these changes Dec 5, 2023
View reviewed changes
Copy link
Contributor

@markgravity markgravity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect to me now ❤️

@ducbm051291
[#498] Update Script: SetUpCICDService to ask for runner type
7db4dcb 
Wwe create 2 folders for each runner type with the same workflows but different runs-on. When the developer chooses a runner type, the chosen type will be copied to the workflow directory.
@ducbm051291
[#498] Create Enum for gifhub runner type
4ec71c2
@ducbm051291
[#498] Remove project workflows and self hosted project workflows in …
cae4b35 
…case CICD using bitrise or codemagic
@ducbm051291
[#498] Update case .none
70932c0
@ducbm051291 ducbm051291 requested a review from blyscuit December 14, 2023 02:06
@ducbm051291 ducbm051291 force-pushed the feature/498-add-option-github-self-hosted-while-generating-project branch from 2c46eb2 to 70932c0 Compare December 14, 2023 02:06
@blyscuit blyscuit added this pull request to the merge queue Dec 21, 2023
Merged via the queue into develop with commit 11790f1 Dec 21, 2023
@blyscuit blyscuit deleted the feature/498-add-option-github-self-hosted-while-generating-project branch December 21, 2023 05:56
@blyscuit blyscuit mentioned this pull request Dec 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyscuit blyscuit blyscuit approved these changes

@markgravity markgravity markgravity approved these changes

@suho suho Awaiting requested review from suho suho is a code owner

@minhnimble minhnimble Awaiting requested review from minhnimble minhnimble is a code owner

@nmint8m nmint8m Awaiting requested review from nmint8m nmint8m is a code owner

@phongvhd93 phongvhd93 Awaiting requested review from phongvhd93 phongvhd93 is a code owner

@vnntsu vnntsu Awaiting requested review from vnntsu vnntsu is a code owner

@Shayokh144 Shayokh144 Awaiting requested review from Shayokh144 Shayokh144 is a code owner

@Thieurom Thieurom Awaiting requested review from Thieurom Thieurom is a code owner

@nkhanh44 nkhanh44 Awaiting requested review from nkhanh44 nkhanh44 is a code owner

Assignees

@ducbm051291 ducbm051291

Labels
type : feature
Projects
None yet
Milestone
4.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@ducbm051291 @blyscuit @markgravity