Conversation
ducbm051291
requested review from
Shayokh144,
Thieurom,
blyscuit,
markgravity,
minhnimble,
nkhanh44,
nmint8m,
phongvhd93,
suho and
vnntsu
as code owners
ducbm051291
changed the title
markgravity
reviewed
Nov 17, 2023
Scripts/Swift/iOSTemplateMaker/Sources/iOSTemplateMaker/SetUpCICDService.swift
Outdated
Show resolved
Hide resolved
blyscuit
reviewed
Nov 17, 2023
Scripts/Swift/iOSTemplateMaker/Sources/iOSTemplateMaker/SetUpCICDService.swift
Outdated
Show resolved
Hide resolved
Contributor
|
I am not sure if we will use the same workflows for self-hosted/gh-hosted. Might make sense for |
Contributor
Author
Good idea 👍 |
ducbm051291
force-pushed
the
feature/498-add-option-github-self-hosted-while-generating-project
branch
2 times, most recently
from
617b7f8 to
622af2a
Compare
ducbm051291
force-pushed
the
feature/498-add-option-github-self-hosted-while-generating-project
branch
from
031e181 to
c1ae290
Compare
Contributor
Author
|
@markgravity @blyscuit Updated new approach and create Enum for Github Runner type |
blyscuit
reviewed
Dec 4, 2023
Scripts/Swift/iOSTemplateMaker/Sources/iOSTemplateMaker/SetUpCICDService.swift
Show resolved
Hide resolved
markgravity
approved these changes
Dec 5, 2023
Contributor
markgravity
left a comment
markgravity
left a comment
There was a problem hiding this comment.
Perfect to me now ❤️
Wwe create 2 folders for each runner type with the same workflows but different runs-on. When the developer chooses a runner type, the chosen type will be copied to the workflow directory.
…case CICD using bitrise or codemagic
ducbm051291
force-pushed
the
feature/498-add-option-github-self-hosted-while-generating-project
branch
from
2c46eb2 to
70932c0
Compare
blyscuit
approved these changes
Dec 15, 2023
blyscuit
deleted the
feature/498-add-option-github-self-hosted-while-generating-project
branch
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What happened 👀
SetUpCICDServiceto ask for runner typeInsight 📝
Proof Of Work 📹