Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GenericLabel over MultiLabel #64

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Use GenericLabel over MultiLabel #64

merged 2 commits into from
Sep 4, 2024

Conversation

tsalo
Copy link
Collaborator

@tsalo tsalo commented Sep 4, 2024

Closes none.

Changes proposed in this pull request

  • Replace MultiLabel with GenericLabel for ApplyTransforms calls.
  • Add a new ApplyTransforms interface that inherits from Niworkflows' FixHeaderApplyTransforms, but with GenericLabel allowed.

Copy link

codecov bot commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 30.93%. Comparing base (25bf8c2) to head (c3c8e25).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
src/fmripost_aroma/interfaces/misc.py 66.66% 4 Missing ⚠️
src/fmripost_aroma/workflows/base.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
- Coverage   31.08%   30.93%   -0.15%     
==========================================
  Files          26       26              
  Lines        2329     2324       -5     
  Branches      362      363       +1     
==========================================
- Hits          724      719       -5     
  Misses       1584     1584              
  Partials       21       21              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tsalo tsalo merged commit 440fdf9 into main Sep 4, 2024
11 of 12 checks passed
@tsalo tsalo deleted the genericlabel branch September 4, 2024 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant