Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Add several wb_command interfaces #51

Merged
merged 5 commits into from
May 1, 2021

Conversation

effigies
Copy link
Member

@effigies effigies commented Apr 30, 2021

Includes the following from #49:

  • cifti-create-dense-timeseries
  • volume-resample
    • Replaces deprecated volume-affine-resample
  • volume-all-labels-to-rois
  • volume-label-export-table
  • volume-label-import

Orig:

How are we doing doctests? Do we have something like nipype.testing.data?

Sorry, something went wrong.

@mgxd
Copy link
Collaborator

mgxd commented Apr 30, 2021

How are we doing doctests?

😅 That's a glaring need atm.

My ideal scenario is we create a fixture to generate dummy data, and then use that (instead of saving files to the repo) to test these interfaces

@effigies effigies force-pushed the enh/volume_affine_resample branch from 3c0ad8b to 22aad2e Compare April 30, 2021 18:11
@pep8speaks
Copy link

pep8speaks commented Apr 30, 2021

Hello @effigies! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2021-04-30 21:07:10 UTC

@effigies effigies force-pushed the enh/volume_affine_resample branch from 0394930 to d71b4f7 Compare April 30, 2021 18:48
@effigies
Copy link
Member Author

My ideal scenario is we create a fixture to generate dummy data, and then use that (instead of saving files to the repo) to test these interfaces

Done.

@effigies effigies force-pushed the enh/volume_affine_resample branch from d71b4f7 to 9bcfd51 Compare April 30, 2021 19:28
@codecov-commenter
Copy link

codecov-commenter commented Apr 30, 2021

Codecov Report

Merging #51 (65e492a) into master (ee30106) will increase coverage by 1.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   27.99%   29.10%   +1.10%     
==========================================
  Files          42       42              
  Lines        3068     3116      +48     
==========================================
+ Hits          859      907      +48     
  Misses       2209     2209              
Impacted Files Coverage Δ
nibabies/interfaces/conftest.py 100.00% <ø> (ø)
nibabies/interfaces/workbench.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee30106...65e492a. Read the comment docs.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@effigies effigies changed the title ENH: Add VolumeAffineResample interface to wb_command -volume-resample ENH: Add several wb_command interfaces Apr 30, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link
Collaborator

@mgxd mgxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks Chris

@mgxd mgxd merged commit 90e6e41 into nipreps:master May 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants