BF: unique json fields #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yarikoptic
commented
Nov 27, 2018
Otherwise it would be inconsistent and populated only with the first run analysis output, so multiple sessions etc would not really get all common values, deminishing its value. See nipy#277
yarikoptic
force-pushed
the
bf-unique-json-fields
branch
from
89f14bc to
3f0e3d9
Compare
yarikoptic
added a commit
to yarikoptic/bids-specification
that referenced
this pull request
Nov 28, 2018
… Inheritance principle It is often useful to look at the top level task*json files to see what is "common" among all subjects/sessions. Listing only the fields with common values is what we also implemented (albeit incorrectly, fix is pending nipy/heudiconv#279) in ReproIn. Upon quick search I also found no "good practice" recommendations in the spec. It might be arguable either spec should or should not include them. I think it should since we already RECOMMEND things. We of cause could place recommendations into a separate subsection somewhere but then they would not be linked to the specific topics and thus would not be attended to. Hence I placed this one right at the section where it is pertinent
This was referenced Dec 5, 2018
|
Unfortunately I am not getting much of comments on bids-standard/bids-specification#102 to clear things up |
|
I think I will include this as is in upcoming release PR and will keep this one open for tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
main goal is to fix #277
TODOs
_acqand possibly other fields in the top level task filename!?- If so, we should somehow automagically clean up possibly existing wrong/rogue files from previous conversions.
- related question for bids-specification: Inheritance principle: clarify the procedure of which files would be considered bids-standard/bids-specification#102