Skip to content

2.2.0 release prep #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 13, 2017
Merged

2.2.0 release prep #555

merged 5 commits into from
Oct 13, 2017

Conversation

effigies
Copy link
Member

@effigies effigies commented Sep 27, 2017

Minor version increment. Fixed a FreeSurfer test that depended on FreeSurfer < v6.0.0.

Closes #540

Open issues/PRs that could go in quickly

Pre-release checklist

Adapted from http://nipy.org/nibabel/devel/make_release.html#release-checklist

@codecov-io
Copy link

codecov-io commented Sep 27, 2017

Codecov Report

Merging #555 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #555      +/-   ##
==========================================
+ Coverage   94.32%   94.32%   +<.01%     
==========================================
  Files         177      177              
  Lines       24689    24691       +2     
  Branches     2638     2638              
==========================================
+ Hits        23288    23290       +2     
  Misses        925      925              
  Partials      476      476
Impacted Files Coverage Δ
nibabel/freesurfer/tests/test_io.py 91.83% <100%> (+0.11%) ⬆️
nibabel/info.py 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c1d0bc...2ca6848. Read the comment docs.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0003%) to 96.271% when pulling 439201c on rel/2.2.0 into dbe74e1 on master.

@effigies effigies force-pushed the rel/2.2.0 branch 2 times, most recently from ddc6597 to 274a6ce Compare September 27, 2017 03:32
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0003%) to 96.271% when pulling 274a6ce on rel/2.2.0 into dbe74e1 on master.

@effigies
Copy link
Member Author

@matthew-brett Do you have time to look at the make sdist-tests errors? Looking at the code, I don't see why those failed.

Apart from open issues to decide whether to work on, that's the only hang-up I have for release.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0003%) to 96.269% when pulling 0a489d4 on rel/2.2.0 into fa76141 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.0003%) to 96.254% when pulling 2ca6848 on rel/2.2.0 into 8c1d0bc on master.

@effigies
Copy link
Member Author

effigies commented Oct 9, 2017

Now two failing chunks of nibabel-release-checks. Any thoughts? I've tried updating the np.printoptions in nifti_images.rst, but that didn't resolve the issue.

@effigies
Copy link
Member Author

@matthew-brett Stuck here. If you can find some time, I could use some help getting this release out.

@matthew-brett
Copy link
Member

Sorry Chris - got a bit snowed under. Sorry too, I should have deleted those from the release doc - when I wrote those checks, we were doing much much less automated testing - and they were before we had scripts being testing. So I think we can ignore those errors. And we should remove those checks.

@effigies
Copy link
Member Author

Sounds good. I'll merge this and release today, if there are no other issues.

@matthew-brett
Copy link
Member

Are you planning to release without the image slicing? I can try to get to this later today.

@effigies
Copy link
Member Author

Can go either way. Obviously would be a nice feature to have, but if you think it needs more time to settle the API and test before it's in an official release, that's fine too.

If you want to see how close it is to ready, we can decide whether to put it in first.

@matthew-brett
Copy link
Member

Let's leave the image slicing for the next release - and plan for another release in a month or so?

@effigies
Copy link
Member Author

Sounds good.

@effigies effigies merged commit ea5c499 into master Oct 13, 2017
@effigies effigies deleted the rel/2.2.0 branch October 13, 2017 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

release?
4 participants