-
Notifications
You must be signed in to change notification settings - Fork 260
MAINT: Effect FutureWarnings, including deprecations #755
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #755 +/- ##
==========================================
+ Coverage 88.38% 88.42% +0.04%
==========================================
Files 188 188
Lines 24008 23992 -16
Branches 4254 4252 -2
==========================================
- Hits 21219 21215 -4
+ Misses 2102 2092 -10
+ Partials 687 685 -2
Continue to review full report at Codecov.
|
f9dcb1c
to
8fd1bd1
Compare
Only pre-test failing (#768), so this is ready for review. I think I've also added a test file to schedule removal of modules and other API elements. I'd considered trying something a bit more automatic, e.g., |
We've been threatening changes for a while, so we can go ahead and effect some.
I'll have another look through for
FutureWarnings
to make sure they're appropriate.The newish deprecation machinery transitions to an error on use when the
until
version is hit, which means we should keep those in a bit longer to ensure people see the error messages. Some of the things I've moved to that machinery promised removal at 3.0, so I'll also make sure we have tests that will fail if they still exist in the release branch.Closes #524.