Skip to content

MAINT: Effect FutureWarnings, including deprecations #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 22, 2019

Conversation

effigies
Copy link
Member

@effigies effigies commented Apr 26, 2019

We've been threatening changes for a while, so we can go ahead and effect some.

I'll have another look through for FutureWarnings to make sure they're appropriate.

The newish deprecation machinery transitions to an error on use when the until version is hit, which means we should keep those in a bit longer to ensure people see the error messages. Some of the things I've moved to that machinery promised removal at 3.0, so I'll also make sure we have tests that will fail if they still exist in the release branch.

Closes #524.

@effigies effigies added this to the 2.5.0 milestone Apr 26, 2019
@codecov-io
Copy link

codecov-io commented Apr 28, 2019

Codecov Report

Merging #755 into master will increase coverage by 0.04%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #755      +/-   ##
==========================================
+ Coverage   88.38%   88.42%   +0.04%     
==========================================
  Files         188      188              
  Lines       24008    23992      -16     
  Branches     4254     4252       -2     
==========================================
- Hits        21219    21215       -4     
+ Misses       2102     2092      -10     
+ Partials      687      685       -2
Impacted Files Coverage Δ
nibabel/testing/__init__.py 97.89% <100%> (+1.08%) ⬆️
nibabel/__init__.py 93.61% <100%> (ø) ⬆️
nibabel/trackvis.py 94.4% <100%> (+1.33%) ⬆️
nibabel/minc.py 100% <100%> (ø) ⬆️
nibabel/minc1.py 90.36% <100%> (+0.11%) ⬆️
nibabel/checkwarns.py 100% <100%> (ø) ⬆️
venv/Lib/site-packages/nibabel/checkwarns.py 100% <0%> (ø) ⬆️
venv/Lib/site-packages/nibabel/minc1.py 90.36% <0%> (+0.11%) ⬆️
venv/Lib/site-packages/nibabel/testing/__init__.py 97.89% <0%> (+1.08%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 97447e2...4746a1c. Read the comment docs.

@effigies effigies force-pushed the mnt/deprecations branch from f9dcb1c to 8fd1bd1 Compare May 25, 2019 21:40
@effigies
Copy link
Member Author

Only pre-test failing (#768), so this is ready for review.

I think nibabel.trackvis are the changes most warranting careful attention.

I've also added a test file to schedule removal of modules and other API elements. I'd considered trying something a bit more automatic, e.g., deprecate_with_version producing appropriate tests, but don't have the energy for that at the moment. A single place to record intent to deprecate I think is sufficient for now.

@effigies effigies merged commit 935079b into nipy:master Jun 22, 2019
@effigies effigies deleted the mnt/deprecations branch June 22, 2019 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Transition FutureWarnings older than X versions to Deprecations?
2 participants