Skip to content

FIX: Python 3 compatibility issue while loading multiframe ECAT files #777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 2, 2019

Conversation

effigies
Copy link
Member

@effigies effigies commented Jul 28, 2019

This PR provides a multiframe ECAT file for our test battery. A couple minor cleanups I saw while looking through this code/docs.

@idoimaging If you would like, you can use my branch as a base to commit your change, e.g.,

git remote add effigies https://github.com/effigies/nibabel.git
git fetch effigies
git checkout -t effigies/fix/ecat_py3
<make change>
git add nibabel/ecat.py
git commit -m <commit message>
git push -u origin fix/ecat_py3

Edit: I went ahead and added the fix with credit.

Fixes #776.

@codecov-io
Copy link

codecov-io commented Jul 30, 2019

Codecov Report

Merging #777 into master will increase coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #777      +/-   ##
==========================================
+ Coverage   89.99%   90.04%   +0.05%     
==========================================
  Files          94       94              
  Lines       12009    12010       +1     
  Branches     2133     2133              
==========================================
+ Hits        10807    10814       +7     
+ Misses        859      851       -8     
- Partials      343      345       +2
Impacted Files Coverage Δ
nibabel/ecat.py 87.98% <66.66%> (+1.71%) ⬆️
nibabel/cmdline/parrec2nii.py 32.73% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b356a64...8b00fd0. Read the comment docs.

@effigies effigies changed the title TEST: Add multiframe ECAT file for testing FIX: Python 3 compatibility issue while loading multiframe ECAT files Jul 30, 2019
@effigies effigies added this to the 2.5.0 milestone Jul 30, 2019
@effigies
Copy link
Member Author

@idoimaging Does this resolve your issue?

@effigies
Copy link
Member Author

effigies commented Aug 2, 2019

We'll trust to the tests.

@effigies effigies merged commit 7ee4aa6 into nipy:master Aug 2, 2019
@effigies effigies deleted the fix/ecat_py3 branch August 2, 2019 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ECAT file support
2 participants