DOC: dcm2niix - details for the output filename pattern, minor typo fix#2512
Merged
effigies merged 2 commits intonipy:masterfrom Mar 27, 2018
Merged
DOC: dcm2niix - details for the output filename pattern, minor typo fix#2512effigies merged 2 commits intonipy:masterfrom
effigies merged 2 commits intonipy:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2512 +/- ##
=========================================
Coverage ? 66.89%
=========================================
Files ? 327
Lines ? 42479
Branches ? 5268
=========================================
Hits ? 28415
Misses ? 13362
Partials ? 702
Continue to review full report at Codecov.
|
effigies
reviewed
Mar 27, 2018
nipype/interfaces/dcm2nii.py
Outdated
| argstr="-f %s", | ||
| desc="Output filename") | ||
| desc="Output filename template (" | ||
| "%a=antenna (coil) number, " \ |
Member
There was a problem hiding this comment.
You don't need these backslashes, since you're inside parentheses.
Member
|
Since it's a small documentation fix, and it looks like we'll need to wait for #2513 to be fixed to release 1.0.2, I'm marking this 1.0.2. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
found uncommitted on the drive, paid price of rebasing and fixing conflicts ;)