Skip to content

DOC: dcm2niix - details for the output filename pattern, minor typo fix #2512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2018

Conversation

yarikoptic
Copy link
Member

found uncommitted on the drive, paid price of rebasing and fixing conflicts ;)

@codecov-io
Copy link

codecov-io commented Mar 26, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@803982c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2512   +/-   ##
=========================================
  Coverage          ?   66.89%           
=========================================
  Files             ?      327           
  Lines             ?    42479           
  Branches          ?     5268           
=========================================
  Hits              ?    28415           
  Misses            ?    13362           
  Partials          ?      702
Flag Coverage Δ
#smoketests 50.83% <ø> (?)
#unittests 64.25% <ø> (?)
Impacted Files Coverage Δ
nipype/interfaces/dcm2nii.py 46.26% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 803982c...230ec4b. Read the comment docs.

@@ -275,7 +275,24 @@ class Dcm2niixInputSpec(CommandLineInputSpec):
xor=['source_names'])
out_filename = traits.Str(
argstr="-f %s",
desc="Output filename")
desc="Output filename template ("
"%a=antenna (coil) number, " \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need these backslashes, since you're inside parentheses.

@effigies
Copy link
Member

Since it's a small documentation fix, and it looks like we'll need to wait for #2513 to be fixed to release 1.0.2, I'm marking this 1.0.2.

@effigies effigies added this to the 1.0.2 milestone Mar 27, 2018
@effigies effigies merged commit 31a1cde into nipy:master Mar 27, 2018
@yarikoptic yarikoptic deleted the bf-minor-desc branch January 11, 2019 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants