Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: push tags to dockerhub #3283

Merged
merged 2 commits into from
May 27, 2021
Merged

Conversation

octomike
Copy link
Contributor

Summary

In our lab we are automatically tracking some tagged and versioned docker images. It would be really great to see all the nipype tags back on dockerhub. I believe this simple change in circleci should make this work. I can only do a trivial "test" here to convince you that it works, but I can't test on circle directly of course. I know it's a stretch because it might break CI, but I hope the change is so small that you consider this merge.

Building:

$ unset CIRCLE_TAG
$ echo docker build \
         --rm=false \
         --tag nipype/nipype:latest \
         --tag nipype/nipype:py36 \
         $(test -z "${CIRCLE_TAG}" || echo --tag nipype/nipype:"${CIRCLE_TAG}") \
         --build-arg BUILD_DATE="$(date -u +"%Y-%m-%dT%H:%M:%SZ")"
docker build --rm=false --tag nipype/nipype:latest --tag nipype/nipype:py36 --build-arg BUILD_DATE=2020-12-17T18:15:18Z

$ CIRCLE_TAG=1.5.1
$ echo docker build \
         --rm=false \
         --tag nipype/nipype:latest \
         --tag nipype/nipype:py36 \
         $(test -z "${CIRCLE_TAG}" || echo --tag nipype/nipype:"${CIRCLE_TAG}") \
         --build-arg BUILD_DATE="$(date -u +"%Y-%m-%dT%H:%M:%SZ")"
docker build --rm=false --tag nipype/nipype:latest --tag nipype/nipype:py36 --tag nipype/nipype:1.5.1 --build-arg BUILD_DATE=2020-12-17T18:16:10Z

Pushing:

$ unset CIRCLE_TAG
$ test -z "${CIRCLE_TAG}" || echo docker push nipype/nipype:"${CIRCLE_TAG}"


$ CIRCLE_TAG=1.5.1
$ test -z "${CIRCLE_TAG}" || echo docker push nipype/nipype:"${CIRCLE_TAG}"
docker push nipype/nipype:1.5.1

The only issue I see is that docker deploys might be duplicated because there is a filter for master and tags now. Not sure if that's a problem.

Acknowledgment

  • (Mandatory) I acknowledge that this contribution will be available under the Apache 2 license.

@effigies effigies mentioned this pull request May 26, 2021
14 tasks
@effigies
Copy link
Member

Looks reasonable. Could you try merging master?

@effigies
Copy link
Member

@octomike I'm going to try to make a release in the next couple days. If you want to try to finish this off, I'd love to include it!

@octomike
Copy link
Contributor Author

That'd be great! I just merged and pushed.

@codecov
Copy link

codecov bot commented May 27, 2021

Codecov Report

Merging #3283 (262ab89) into master (f980447) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3283   +/-   ##
=======================================
  Coverage   65.01%   65.01%           
=======================================
  Files         302      302           
  Lines       40035    40035           
  Branches     5291     5291           
=======================================
  Hits        26029    26029           
  Misses      12935    12935           
  Partials     1071     1071           
Flag Coverage Δ
unittests 64.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f980447...262ab89. Read the comment docs.

@effigies effigies added this to the 1.6.1 milestone May 27, 2021
@effigies
Copy link
Member

Awesome, thanks. If you're not already in the Zenodo file and would like to be included as an author on releases, please post on #3336 with your name, affiliation and ORCID.

@effigies effigies merged commit ea4a2d7 into nipy:master May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants