Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In our lab we are automatically tracking some tagged and versioned docker images. It would be really great to see all the nipype tags back on dockerhub. I believe this simple change in circleci should make this work. I can only do a trivial "test" here to convince you that it works, but I can't test on circle directly of course. I know it's a stretch because it might break CI, but I hope the change is so small that you consider this merge.
Building:
Pushing:
The only issue I see is that docker deploys might be duplicated because there is a filter for
master
andtags
now. Not sure if that's a problem.Acknowledgment