Skip to content

ENH: Interface for R #3291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 19 commits into from
Jun 2, 2021
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
127 changes: 127 additions & 0 deletions nipype/interfaces/r.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,127 @@
# -*- coding: utf-8 -*-
# emacs: -*- mode: python; py-indent-offset: 4; indent-tabs-mode: nil -*-
# vi: set ft=python sts=4 ts=4 sw=4 et:
"""Interfaces to run R scripts."""
import os

from .. import config
from .base import (
CommandLineInputSpec,
InputMultiPath,
isdefined,
CommandLine,
traits,
File,
Directory,
)


def get_r_command():
if "NIPYPE_NO_R" in os.environ:
return None
r_cmd = os.getenv("RCMD", default="R")

return r_cmd if which(r_cmd) else None


no_r = get_r_command() is None


class RInputSpec(CommandLineInputSpec):
""" Basic expected inputs to R interface """

script = traits.Str(
argstr='-e "%s"', desc="R code to run", mandatory=True, position=-1
)
# non-commandline options
rfile = traits.Bool(True, desc="Run R using R script", usedefault=True)
script_file = File(
"pyscript.R", usedefault=True, desc="Name of file to write R code to"
)


class RCommand(CommandLine):
"""Interface that runs R code

>>> import nipype.interfaces.r as r
>>> r = r.RCommand(rfile=False) # don't write script file
>>> r.inputs.script = "Sys.getenv('USER')"
>>> out = r.run() # doctest: +SKIP
"""

_cmd = get_r_command()
_default_r_cmd = None
_default_rfile = None
input_spec = RInputSpec

def __init__(self, r_cmd=None, **inputs):
"""initializes interface to r
(default 'R')
"""
super(RCommand, self).__init__(**inputs)
if r_cmd and isdefined(r_cmd):
self._cmd = r_cmd
elif self._default_r_cmd:
self._cmd = self._default_r_cmd

if self._default_rfile and not isdefined(self.inputs.rfile):
self.inputs.rfile = self._default_rfile

# For r commands force all output to be returned since r
# does not have a clean way of notifying an error
self.terminal_output = "allatonce"

@classmethod
def set_default_r_cmd(cls, r_cmd):
"""Set the default R command line for R classes.

This method is used to set values for all R
subclasses. However, setting this will not update the output
type for any existing instances. For these, assign the
<instance>.inputs.r_cmd.
"""
cls._default_r_cmd = r_cmd

@classmethod
def set_default_rfile(cls, rfile):
"""Set the default R script file format for R classes.

This method is used to set values for all R
subclasses. However, setting this will not update the output
type for any existing instances. For these, assign the
<instance>.inputs.rfile.
"""
cls._default_rfile = rfile

def _run_interface(self, runtime):
self.terminal_output = "allatonce"
runtime = super(RCommand, self)._run_interface(runtime)
if "R code threw an exception" in runtime.stderr:
self.raise_exception(runtime)
return runtime

def _format_arg(self, name, trait_spec, value):
if name in ["script"]:
argstr = trait_spec.argstr
return self._gen_r_command(argstr, value)
return super(RCommand, self)._format_arg(name, trait_spec, value)

def _gen_r_command(self, argstr, script_lines):
""" Generates commands and, if rfile specified, writes it to disk."""
if not self.inputs.rfile:
# replace newlines with ;, strip comments
script = "; ".join([
line
for line in script_lines.split("\n")
if not line.strip().startswith("#")
])
# escape " and $
script = script.replace('"','\\"')
script = script.replace('$','\\$')
else:
script_path = os.path.join(os.getcwd(), self.inputs.script_file)
with open(script_path, "wt") as rfile:
rfile.write(script_lines)
script = "source('%s')" % script_path

return argstr % script
100 changes: 100 additions & 0 deletions nipype/interfaces/tests/test_r.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,100 @@
# -*- coding: utf-8 -*-
# emacs: -*- mode: python; py-indent-offset: 4; indent-tabs-mode: nil -*-
# vi: set ft=python sts=4 ts=4 sw=4 et:
import os

import pytest
import nipype.interfaces.r as r

r_cmd = r.get_r_command()
no_r = r_cmd is None
if not no_r:
r.RCommand.set_default_r_cmd(r_cmd)


def clean_workspace_and_get_default_script_file():
# Make sure things are clean.
default_script_file = r.RInputSpec().script_file
if os.path.exists(default_script_file):
os.remove(
default_script_file
) # raise Exception('Default script file needed for tests; please remove %s!' % default_script_file)
return default_script_file


@pytest.mark.skipif(no_r, reason="R is not available")
def test_cmdline():
default_script_file = clean_workspace_and_get_default_script_file()

ri = r.RCommand(script="1 + 1", script_file="testscript", rfile=False)

assert ri.cmdline == r_cmd + (
' -e "1 + 1"'
)

assert ri.inputs.script == "1 + 1"
assert ri.inputs.script_file == "testscript"
assert not os.path.exists(ri.inputs.script_file), "scriptfile should not exist"
assert not os.path.exists(
default_script_file
), "default scriptfile should not exist."

@pytest.mark.skipif(no_r, reason="R is not available")
def test_r_init():
default_script_file = clean_workspace_and_get_default_script_file()

assert r.RCommand._cmd == "R"
assert r.RCommand.input_spec == r.RInputSpec

assert r.RCommand().cmd == r_cmd
rc = r.RCommand(r_cmd="foo_m")
assert rc.cmd == "foo_m"


@pytest.mark.skipif(no_r, reason="R is not available")
def test_run_interface(tmpdir):
default_script_file = clean_workspace_and_get_default_script_file()

rc = r.RCommand(r_cmd="foo_m")
assert not os.path.exists(default_script_file), "scriptfile should not exist 1."
with pytest.raises(ValueError):
rc.run() # script is mandatory
assert not os.path.exists(default_script_file), "scriptfile should not exist 2."
if os.path.exists(default_script_file): # cleanup
os.remove(default_script_file)

rc.inputs.script = "a=1;"
assert not os.path.exists(default_script_file), "scriptfile should not exist 3."
with pytest.raises(IOError):
rc.run() # foo_m is not an executable
assert os.path.exists(default_script_file), "scriptfile should exist 3."
if os.path.exists(default_script_file): # cleanup
os.remove(default_script_file)

cwd = tmpdir.chdir()

# bypasses ubuntu dash issue
rc = r.RCommand(script="foo;", rfile=True)
assert not os.path.exists(default_script_file), "scriptfile should not exist 4."
with pytest.raises(RuntimeError):
rc.run()
assert os.path.exists(default_script_file), "scriptfile should exist 4."
if os.path.exists(default_script_file): # cleanup
os.remove(default_script_file)

# bypasses ubuntu dash issue
res = r.RCommand(script="a=1;", rfile=True).run()
assert res.runtime.returncode == 0
assert os.path.exists(default_script_file), "scriptfile should exist 5."
cwd.chdir()


@pytest.mark.skipif(no_r, reason="R is not available")
def test_set_rcmd():
default_script_file = clean_workspace_and_get_default_script_file()

ri = r.RCommand()
ri.set_default_r_cmd("foo")
assert not os.path.exists(default_script_file), "scriptfile should not exist."
assert ri._default_r_cmd == "foo"
ri.set_default_r_cmd(r_cmd)