Adding user supplied common labels to helm chart#358
Merged
lucchmielowski merged 9 commits intonirmata:mainfrom Jul 22, 2025
Merged
Adding user supplied common labels to helm chart#358lucchmielowski merged 9 commits intonirmata:mainfrom
lucchmielowski merged 9 commits intonirmata:mainfrom
Conversation
lucchmielowski
requested changes
Jul 19, 2025
Contributor
lucchmielowski
left a comment
lucchmielowski
left a comment
There was a problem hiding this comment.
Hi @stelah1423 ! 👋 Thanks for the addition !
Added some possible changes. Feel free to let me know if I missed something 👍
Co-authored-by: Luc Chmielowski <lucchmielowski@users.noreply.github.com>
Co-authored-by: Luc Chmielowski <lucchmielowski@users.noreply.github.com>
Contributor
Author
|
@lucchmielowski Excellent suggestions; updates made! |
Contributor
|
Thanks @stelah1423 ! 🙏 Could you regenerate the helm-doc as well ? 😅 |
lucchmielowski
approved these changes
Jul 22, 2025
Contributor
Author
|
@lucchmielowski Looks like you got to it before I did! Sorry about that and thanks again for the quick turnaround on this. |
lucchmielowski
added a commit
to lucchmielowski/kyverno-notation-aws
that referenced
this pull request
Nov 26, 2025
…#358) * Update _labels.tpl with common labels logic from values * Update values.yaml with commonLabels * Update README.md with commonLabels * Update charts/kyverno-notation-aws/values.yaml Co-authored-by: Luc Chmielowski <lucchmielowski@users.noreply.github.com> * Update charts/kyverno-notation-aws/values.yaml Co-authored-by: Luc Chmielowski <lucchmielowski@users.noreply.github.com> * Update _labels.tpl * fix doc --------- Co-authored-by: Luc Chmielowski <lucchmielowski@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adopting this chart, I found the need to have a mechanism, like many other charts, where we could add common labels to all resources where applicable. These changes worked for us, and could be helpful since it appears there is work being done to support releasing this chart publicly.
{}and including comments on the structure if defined