Support Jenkins2 pipeline #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Helo, any change? are you going to merge this PR? |
|
Hi, The problem is following:
Do you know how to fix it? |
|
Is the Build Status supposed to be updated in bitbucket? I am getting this even for a success build:
|
|
confirmed the issue with updating the PR build status after the build completes |
|
problem is caused by BitbucketBuildListener, the extension will not be invoked on pipeline jobs |
Replace use of AbstractProject with Job to fix ClassCastException thrown when using the plugin in a pipeline job The fix is "not" complete, it remains to find a replacement to the call AbstractProject.isDisabled used to decide if the build should be skipped Previously called in BitbucketBuildTrigger.run() fixes nishio-dens#94
looks like pipeline jobs don't have a disable option
BitbucketBuildListener was not invoked on pipeline jobs Change BitbucketBuildListener to extend from RunListener<Run<?, ?>> so it will invoked to update job description and PR build result
frodeaa
force-pushed
the
jenkins2-pipeline-support-94
branch
from
d160d97 to
0debdfb
Compare
|
@damovsky rebase done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace use of AbstractProject with Job to fix ClassCastException thrown when using the plugin in a pipeline job
Note The previous behaviour to skip the build if the project was disabled is currently not implemented. TheJobclass does not have the methodAbstractProject.isDisabled(), so it remains to find an alternative way to do the check...Fixes #94