fixes #1093

[anidotnet]

Summary by CodeRabbit

Release Notes

• New Features

  • Added a new test case for repository operations.

• Improvements

  • Enhanced serialization mechanism for database values.
  • Improved resource management in index clearing.
  • Simplified singleton access in the DBNull class using Lombok annotations.

• Tests

  • Added new test method to verify repository behavior.

The release focuses on internal improvements and resource management with minimal user-facing changes.

[coderabbitai]

Walkthrough

The pull request introduces several modifications across different components of the Nitrite database project. These changes include a new serializer for DBValue objects in the RocksDB adapter, a test method for issue tracking, resource management improvements in the IndexManager, and a simplification of the DBNull class using Lombok annotations. The modifications aim to enhance serialization, testing capabilities, resource handling, and code readability.

Changes

File	Change Summary
nitrite-rocksdb-adapter/src/main/java/org/dizitart/no2/rocksdb/formatter/NitriteSerializers.java	Added DBValueSerializer for custom DBValue serialization, replacing JavaSerializer
nitrite-rocksdb-adapter/src/test/java/org/dizitart/no2/NitriteTest.java	Added testIssue1093() test method for Receipt repository operations
nitrite/src/main/java/org/dizitart/no2/collection/operation/IndexManager.java	Added indexMap.close() in clearAll() method for improved resource management
nitrite/src/main/java/org/dizitart/no2/common/DBNull.java	Replaced getInstance() method with Lombok @Getter annotation

Poem

🐰 In the realm of code, where bits take flight,
Serializers dance with Lombok's might,
Resources close, tests leap with glee,
Nitrite evolves, so elegantly free!
A rabbit's code, both swift and bright 🚀

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between de9024f and 9ea3e08.

📒 Files selected for processing (2)

• nitrite-rocksdb-adapter/src/main/java/org/dizitart/no2/rocksdb/formatter/NitriteSerializers.java (1 hunks)
• nitrite-rocksdb-adapter/src/test/java/org/dizitart/no2/NitriteTest.java (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (2)

• nitrite-rocksdb-adapter/src/test/java/org/dizitart/no2/NitriteTest.java
• nitrite-rocksdb-adapter/src/main/java/org/dizitart/no2/rocksdb/formatter/NitriteSerializers.java

⏰ Context from checks skipped due to timeout of 90000ms (14)

• GitHub Check: Verify GraalVM 17 compatibility on macos-latest
• GitHub Check: Verify GraalVM 21 compatibility on windows-latest
• GitHub Check: Verify GraalVM 17 compatibility on windows-latest
• GitHub Check: Build with Java 17 in Windows
• GitHub Check: Verify GraalVM 21 compatibility on ubuntu-latest
• GitHub Check: Build with Java 17 in Ubuntu
• GitHub Check: Build with Java 11 in Windows
• GitHub Check: Build with Java 17 in MacOS
• GitHub Check: Build with Java 11 in Ubuntu
• GitHub Check: Verify GraalVM 17 compatibility on ubuntu-latest
• GitHub Check: Build with Java 11 in MacOS
• GitHub Check: Analyze (java)
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: Analyze (java)

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[coderabbitai]

Actionable comments posted: 2

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d550be1 and de9024f.

📒 Files selected for processing (4)

• nitrite-rocksdb-adapter/src/main/java/org/dizitart/no2/rocksdb/formatter/NitriteSerializers.java (3 hunks)
• nitrite-rocksdb-adapter/src/test/java/org/dizitart/no2/NitriteTest.java (1 hunks)
• nitrite/src/main/java/org/dizitart/no2/collection/operation/IndexManager.java (1 hunks)
• nitrite/src/main/java/org/dizitart/no2/common/DBNull.java (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (15)

• GitHub Check: Verify GraalVM 21 compatibility on macos-latest
• GitHub Check: Verify GraalVM 17 compatibility on macos-latest
• GitHub Check: Verify GraalVM 21 compatibility on windows-latest
• GitHub Check: Verify GraalVM 17 compatibility on windows-latest
• GitHub Check: Codacy Static Code Analysis
• GitHub Check: Verify GraalVM 21 compatibility on ubuntu-latest
• GitHub Check: Build with Java 17 in MacOS
• GitHub Check: Verify GraalVM 17 compatibility on ubuntu-latest
• GitHub Check: Build with Java 17 in Windows
• GitHub Check: Build with Java 11 in MacOS
• GitHub Check: Build with Java 17 in Ubuntu
• GitHub Check: Build with Java 11 in Windows
• GitHub Check: Analyze (java)
• GitHub Check: Build with Java 11 in Ubuntu
• GitHub Check: Analyze (java)

🔇 Additional comments (3)

nitrite/src/main/java/org/dizitart/no2/common/DBNull.java (1)

3-13: LGTM! Good use of Lombok to reduce boilerplate.

The change simplifies the code by using Lombok's @Getter annotation while maintaining the singleton pattern functionality.

nitrite/src/main/java/org/dizitart/no2/collection/operation/IndexManager.java (1)

116-116: Good catch! Fixed potential resource leak.

Adding indexMap.close() ensures proper cleanup of resources after clearing the index map.

nitrite-rocksdb-adapter/src/main/java/org/dizitart/no2/rocksdb/formatter/NitriteSerializers.java (1)

246-246: LGTM! Proper registration of custom serializer.

The registration of the new DBValueSerializer for DBValue class is correct.