Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update for kernels >= 4.14 #5

Merged
merged 1 commit into from
Apr 9, 2020
Merged

update for kernels >= 4.14 #5

merged 1 commit into from
Apr 9, 2020

Conversation

henning-schild
Copy link

remove include that is not needed anymore

Signed-off-by: Henning Schild [email protected]

remove include that is not needed anymore

Signed-off-by: Henning Schild <[email protected]>
@henning-schild
Copy link
Author

is this repo unmaintained?

@teleshoes
Copy link

hey, sorry.
i mean, its not unmaintained, but its not exactly NOT unmaintained either. i update it only to get tpacpi-bat working when it breaks for me personally.
ill try to take a look at this soon

@henning-schild
Copy link
Author

Thanks, because i am working on another patch that i would like to get merged. (here?) That is also coming from tpacpi-bat.

@teleshoes teleshoes merged commit 70b9c80 into nix-community:master Apr 9, 2020
@teleshoes
Copy link

teleshoes commented Apr 9, 2020

hey look, it only took me 1 full year to actually test this! ...sorry :(

EDIT: ok not QUITE a fully year, but we can take on the additional full year it took me to notice the pull req, and call it 2 full years

@henning-schild
Copy link
Author

oh progress ;) thx

i do not even remember what that other patch was, interesting to see that it took you so long to adopt >= 4.15

what is "upstream" if this is potentially not?

@teleshoes
Copy link

teleshoes commented Apr 9, 2020

unfortunately this is as upstream as it gets, afaik.
(tpacpi-bat is actually mine, acpi_call i only maintain because its a dependency of tpacpi-bat)

(EDIT: ha! "maintain"...)

@henning-schild
Copy link
Author

not sure about other distros but gentoo has both ... not sure how many users there are

https://github.com/gentoo/gentoo/tree/master/app-laptop/tpacpi-bat
https://github.com/gentoo/gentoo/tree/master/sys-power/acpi_call

maybe that helps in terms of motivation, there are people using it!
And i guess other distros like maybe arch have it as well

@teleshoes
Copy link

yea i suppose i should maintain these better. please feel free to pull-req any patches you like. i will do at least basic code review and testing on at least one thinkpad.

@Mic92
Copy link
Member

Mic92 commented May 7, 2020

Btw. The NixOS community also maintains a fork now. Maybe we can consolidate the effort somehow: mkottman#89

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants