feat: convert ruff lints to flake checks#470
Open
plaflamme wants to merge 2 commits into
Open
Conversation
Had to add `--impure` to the call due to the following error otherwise:
```
error:
… while checking flake output 'packages'
at /nix/store/5cjz7jyqyfr5vq8b6bjs24vdnvdhy9rb-source/flake.nix:118:7:
117|
118| packages = forEachSystem (system:
| ^
119| let
… while checking the derivation 'packages.x86_64-linux.bootstrap-aarch64'
at /nix/store/dg3hg3ksr5sl3adskxiwj7357z47ggvr-source/lib/attrsets.nix:977:47:
976| */
977| nameValuePair = name: value: { inherit name value; };
| ^
978|
(stack trace truncated; use '--show-trace' to show the full, detailed trace)
error: 'builtins.storePath' is not allowed in pure evaluation mode
```
Author
Collaborator
|
wonder why it's rebuilding so much... |
Collaborator
|
Because the flake inputs were updated, seems to be an unrelated change |
Author
As mentioned in the PR notes, I had to upgrade the dependencies because the But I believe the cause of rebuild might actually be caused by |
Author
|
@t184256 @Gerschtli sorry for the additional ping, but any update on this one? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on #412 and is an answer to this comment
Notes:
.pyfiles and then runningnix flake check --impure)--impureargument, I'm not sure why the error kicks in (see 505cc01), but it complains about referencingbuiltins.storePathnix flake check --impurewhich also runs the pre-existing nix linting checknix flake updateto get a more recentruffversion (0.2.x -> 0.12.x which is pretty substantial)cc @t184256