-
-
Notifications
You must be signed in to change notification settings - Fork 351
plugins/coverage: migrate to mkNeovim #3790
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
introduced by: #2638 |
e1052f9
to
edf4477
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for giving this a try.
A few remarks:
- You need to properly deprecate the old
keymaps
andkeymapsSilent
options as they do not map to a newsettings.X
option. (UsemkRemovedOptionModule
).
They should not be inoptionsRenamedToSettings
. This is made for options that were mapped to the plugin's native options (i.e.autoReload -> auto_reload
). - You need to import the
deprecations.nix
(seenixvim/plugins/by-name/lspkind/default.nix
Lines 19 to 20 in bb9d744
# TODO: introduced 2025-07-16: remove after 25.11 inherit (import ./deprecations.nix lib) deprecateExtraOptions optionsRenamedToSettings;
8d7c6af
to
b2be75d
Compare
Thank you! yeah after taking a deeper look into the upstream repo I see that I didnt really need keymaps nor keymapsSilent :) |
b2be75d
to
4263333
Compare
4263333
to
abe2bf8
Compare
a5b62f3
to
5fbec45
Compare
just rebased this branch FYI |
5fbec45
to
a047564
Compare
a047564
to
0f62695
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a minor stylistic change.
Thanks a lot @FKouhai for your patience!
I think that this is PR is now good to be merged :)
awesome! thank you very much for your reviews |
initial work done:
nix develop --interactive
and picking coverage