plugins/navbuddy: migrate to mkNeovimPlugin #3804
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
saygo-png
force-pushed
the
navbuddy-mkNeovimPlugin
branch
2 times, most recently
from
0c706fc to
3b340b3
Compare
GaetanLepage
approved these changes
Oct 11, 2025
There was a problem hiding this comment.
Thanks!
@MattSturgeon are you fine with me getting rid of the top-level actions in a follow-up PR?
|
I'll just get rid of |
saygo-png
force-pushed
the
navbuddy-mkNeovimPlugin
branch
from
3b340b3 to
3a666f5
Compare
Signed-off-by: saygo-png <[email protected]>
saygo-png
force-pushed
the
navbuddy-mkNeovimPlugin
branch
from
3a666f5 to
ed62f1e
Compare
khaneliman
approved these changes
Oct 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not deprecating "keymapsSilent" as it was a noop. I presume it was meant to be used in the
mappingsoption but never was. Not fixing it because I feel that if the user wants to customize the binds like that, they should just be using our toplevelkeymapsoption or usingextraConfigLua*.defaults: https://github.com/hasansujon786/nvim-navbuddy/blob/18802efb91bcfafc54aed513ef97da1dfeae4059/lua/nvim-navbuddy/init.lua#L137-L273
I removed the
fuzzy_finderbind from the defaults test as it throws without telescope and with the integration set tonil. (I'm assuming there is some logic that removes that bind if telescope/snacks isn't found but i can't find it)One major issue is that the
mappingsoption is merged withsettingsusing//so it does not use the nixpkgs merging system. Not sure how I could add that in though as this value gets transpiled to Lua, so i can't just uselib.mkMerge. This is problematic as keymaps can both be set using the plugin's toplevelmappingsoption and thesettingsone.