-
Notifications
You must be signed in to change notification settings - Fork 726
ioctl: add support for cygwin #2715
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
ioctl: add support for cygwin #2715
Conversation
|
I was going to unpin and update libc because it is needed for downstream projects, but it seems to need a pending fix in libc. Will wait for it before trying again. |
9daa3b5 to
72e394a
Compare
|
Cleaning up commits. |
72e394a to
ddcf4dd
Compare
|
Seems like most platforms compile fine, it's libc itself that's failing to build for those platforms? |
|
@tgross35 Similar missing issue like rust-lang/libc#4913 ? |
|
NetBSD: the target was pretty broken, we used that as an opportunity to do some minor breakage in https://github.com/rust-lang/libc/releases/tag/0.2.178. The special casing here will need to be removed Lines 94 to 97 in ba63e90
uclibc: Looks like this was unintentional from rust-lang/libc@2fe1d91. |
780b6cb to
53f117c
Compare
|
Maybe the libc fixes should be split off into a different PR? Or combined into #2709? Anyways, cleaned up commits for now. |
|
Does not this repo have bot for crate bump? |
|
For uclibc, rust-lang/libc@3dad489 and rust-lang/libc@e0ed72d. I'll cut a new release tomorrowish. |
No 0.2 backport? |
|
What do you mean? |
|
I think backport means |
|
I don't usually do the backports until just before I release. I have it cooking locally but just haven't had a chance to wrap it up yet.
Certainly nobody's fault 🙂 the past two releases have been ~10kloc which is way higher than the average of around 1-3k, so there were some things that snuck in. I'll ping on this thread when the release is out. |
53f117c to
f759d55
Compare
What does this PR do
Enable
ioctlsupport for Cygwin, based on the Cygwin C headersChecklist:
CONTRIBUTING.md