Skip to content

Conversation

@500-internal-server-error
Copy link

@500-internal-server-error 500-internal-server-error commented Dec 16, 2025

What does this PR do

Enable ioctl support for Cygwin, based on the Cygwin C headers

Checklist:

  • I have read CONTRIBUTING.md
  • I have written necessary tests and rustdoc comments
  • A change log has been added if this PR modifies nix's API

@500-internal-server-error
Copy link
Author

500-internal-server-error commented Dec 17, 2025

I was going to unpin and update libc because it is needed for downstream projects, but it seems to need a pending fix in libc. Will wait for it before trying again.

@500-internal-server-error
Copy link
Author

Cleaning up commits.

@500-internal-server-error
Copy link
Author

Seems like most platforms compile fine, it's libc itself that's failing to build for those platforms?

@500-internal-server-error 500-internal-server-error marked this pull request as ready for review January 6, 2026 05:23
@oech3
Copy link

oech3 commented Jan 6, 2026

#2715 (comment)

@tgross35 Similar missing issue like rust-lang/libc#4913 ?

@tgross35
Copy link

tgross35 commented Jan 6, 2026

NetBSD: the target was pretty broken, we used that as an opportunity to do some minor breakage in https://github.com/rust-lang/libc/releases/tag/0.2.178. The special casing here will need to be removed

nix/src/sys/event.rs

Lines 94 to 97 in ba63e90

#[cfg(any(freebsdlike, apple_targets, target_os = "openbsd"))]
type type_of_udata = *mut libc::c_void;
#[cfg(target_os = "netbsd")]
type type_of_udata = intptr_t;
and #2709 for IFF_NOTRAILERS.

uclibc: Looks like this was unintentional from rust-lang/libc@2fe1d91.

@500-internal-server-error
Copy link
Author

Maybe the libc fixes should be split off into a different PR? Or combined into #2709?

Anyways, cleaned up commits for now.

@oech3
Copy link

oech3 commented Jan 6, 2026

Does not this repo have bot for crate bump?

@tgross35
Copy link

tgross35 commented Jan 6, 2026

For uclibc, rust-lang/libc@3dad489 and rust-lang/libc@e0ed72d. I'll cut a new release tomorrowish.

@500-internal-server-error
Copy link
Author

I'll cut a new release tomorrowish.

No 0.2 backport?

@tgross35
Copy link

tgross35 commented Jan 8, 2026

What do you mean?

@oech3
Copy link

oech3 commented Jan 8, 2026

I think backport means 0.2.180 (no major bump). Sorry for triggering too many release (stty, musl ,etc...

@tgross35
Copy link

tgross35 commented Jan 8, 2026

I don't usually do the backports until just before I release. I have it cooking locally but just haven't had a chance to wrap it up yet.

Sorry for triggering too many release (stty, musl ,etc...

Certainly nobody's fault 🙂 the past two releases have been ~10kloc which is way higher than the average of around 1-3k, so there were some things that snuck in.

I'll ping on this thread when the release is out.

@tgross35
Copy link

tgross35 commented Jan 8, 2026

It's out https://github.com/rust-lang/libc/releases/tag/0.2.180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants