Skip to content

Fix Angular package version conflicts from Snyk vulnerability patch#33

Closed
Copilot wants to merge 3 commits intosnyk-fix-5bd30ebaf9254083bf717e9a576e11befrom
copilot/sub-pr-31
Closed

Fix Angular package version conflicts from Snyk vulnerability patch#33
Copilot wants to merge 3 commits intosnyk-fix-5bd30ebaf9254083bf717e9a576e11befrom
copilot/sub-pr-31

Conversation

Copy link
Copy Markdown

Copilot AI commented Dec 27, 2025

The Snyk vulnerability fix in PR #31 upgraded only @angular/common and @angular/compiler to v19 while leaving other Angular packages at v17, causing peer dependency conflicts.

Updated all Angular packages to v19.2.x:

  • Core packages: animations, core, forms, platform-browser, platform-browser-dynamic, router
  • Build tools: cli, devkit/build-angular, compiler-cli
  • ng-packagr: v17.0.1 → v19.0.0

Updated required peer dependencies:

  • zone.js: v0.14.2 → v0.15.0 (Angular v19 requirement)
  • typescript: v5.2.2 → v5.7.2 (Angular v19 requirement)
  • rxjs: v6.6.0 → v7.8.0 (Angular v19 requirement)

Updated library peerDependencies in projects/crypto-browser-storage/package.json to accept Angular ^19.0.0

Build verified successful with updated dependencies.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 2 commits December 27, 2025 13:51
Co-authored-by: sefatanam <37630292+sefatanam@users.noreply.github.com>
Co-authored-by: sefatanam <37630292+sefatanam@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback from review on Snyk vulnerability fix PR Fix Angular package version conflicts from Snyk vulnerability patch Dec 27, 2025
Copilot AI requested a review from sefatanam December 27, 2025 13:54
@sefatanam sefatanam marked this pull request as ready for review December 27, 2025 13:58
@sefatanam
Copy link
Copy Markdown
Member

@copilot check everything and merge.

Copy link
Copy Markdown
Author

Copilot AI commented Dec 27, 2025

@copilot check everything and merge.

I've verified everything is working correctly:

Build: Successful (Angular package builds without errors)
Dependencies: All Angular packages upgraded to v19.2.x with compatible peer dependencies
Security: 0 vulnerabilities found in npm audit
Package versions: All Angular core packages, build tools, zone.js, typescript, rxjs, and ng-packagr are now at compatible v19 versions

The changes resolve the peer dependency conflicts from the original Snyk fix. However, I don't have the ability to merge pull requests - you'll need to merge this PR manually through the GitHub interface.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants