Make playground maps shareable by persisting data to the URL #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpojer
reviewed
May 16, 2024
cpojer
reviewed
May 16, 2024
docs/content/examples/map-editor.tsx
Outdated
Comment on lines
26
to
71
| const toMapObject = (data: string | null): MapObject | null => { | ||
| if (!data) { | ||
| return null; | ||
| } | ||
|
|
||
| try { | ||
| return JSON.parse(data); | ||
| } catch { | ||
| return null; | ||
| } | ||
| }; |
There was a problem hiding this comment.
I feel like we should actually parse and validate each field here to match the shape of MapObject, otherwise if data input is wrong it will fail later in the code and is confusing.
There was a problem hiding this comment.
Do you have a preferred strategy for the validation? We could introduce something like zod or just add some lightweight validation for each field checking if it's present and if not, returning a default/empty value. I'd lean towards the latter in this case.
cpojer
reviewed
May 16, 2024
cpojer
reviewed
May 16, 2024
cpojer
requested changes
May 16, 2024
|
@cpojer No rush, and yes, I can definitely update it! All good feedback |
cpojer
force-pushed
the
add-share-link-to-playground-map-editor
branch
from
0c876cf to
d89db7d
Compare
|
Thanks for the contribution, this is great! |
tjamesmac
pushed a commit
to tjamesmac/athena-crisis
that referenced
this pull request
May 17, 2024
…ch#18) Co-authored-by: cpojer <[email protected]>
cpojer
added a commit
that referenced
this pull request
May 19, 2024
Co-authored-by: Connor Lindsey <[email protected]> GitOrigin-RevId: 80499df94c87243652a05c36fa5c43bd079fae6b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #13
Todo
idandslug