Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add one-click button to run and edit the code in CodeSandbox cloud IDE #20

Merged
merged 6 commits into from
May 21, 2024

Conversation

tomsdev
Copy link
Contributor

@tomsdev tomsdev commented May 17, 2024

Hello, thanks for open-sourcing the game, this is a dream come true!

I think adding a very easy and quick way to run and edit the code will help getting new contributors.

I tried running it with Stackblitz but unfortunately they don't support Node version 20 yet and it seems Prisma cannot fully run inside it.
However I tried CodeSandbox and it runs well! I just had to decrease the required minimal version of pnpm and added a little bit of CodeSandbox specific configuration so that nothing needs to be configured and the project can run immediatly and open the demo at localhost:3003 automatically.

You can try it here:
https://codesandbox.io/p/github/tomsdev/athena-crisis

@cpojer
Copy link
Contributor

cpojer commented May 17, 2024

This is great! Could you undo the changes to the package.json and pnpm-lock.yaml? I'd love to allow using earlier versions of pnpm but the lockfile format changed so there is a lot of churn if people use different pnpm versions.

@cpojer cpojer merged commit acc9d5b into nkzw-tech:main May 21, 2024
2 checks passed
@cpojer
Copy link
Contributor

cpojer commented May 21, 2024

The config was contributed by @Saeris in #26, so I reverted all changes from here except the README additions. Thanks for bringing up the idea!

cpojer added a commit that referenced this pull request May 21, 2024
cpojer added a commit that referenced this pull request May 21, 2024
#20)

Co-authored-by: Christoph Nakazawa <[email protected]>
GitOrigin-RevId: f97faeb530686616347c8384325c41888aef18de
cpojer added a commit that referenced this pull request May 21, 2024
#20)

Co-authored-by: Thomas L <[email protected]>
GitOrigin-RevId: ab336f5d5c32a81f743dc5d373173b97d94b2b8c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants