Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix coverage job #4595

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Fix coverage job #4595

merged 1 commit into from
Jan 15, 2025

Conversation

nlohmann
Copy link
Owner

@nlohmann nlohmann commented Jan 12, 2025

  • make sure gcov and gcc use the same version
  • replace deprecated parameter lcov_branch_coverage with branch_coverage
  • suppressed errors

The fix reduces the coverage, but the uncovered lines are all false positives, like the second line of a multi-line return statement where the first line is marked as covered.

@coveralls
Copy link

coveralls commented Jan 12, 2025

Coverage Status

coverage: 99.184% (-0.5%) from 99.639%
when pulling fe00b36 on fix-coverage
into 2d42229 on develop.

@nlohmann nlohmann marked this pull request as ready for review January 12, 2025 21:05
@nlohmann nlohmann added the review needed It would be great if someone could review the proposed changes. label Jan 12, 2025
@github-actions github-actions bot added M and removed S labels Jan 15, 2025
Signed-off-by: Niels Lohmann <[email protected]>
@github-actions github-actions bot added S and removed M labels Jan 15, 2025
@nlohmann nlohmann added this to the Release 3.11.4 milestone Jan 15, 2025
@nlohmann nlohmann merged commit ad2ee18 into develop Jan 15, 2025
124 of 125 checks passed
@nlohmann nlohmann deleted the fix-coverage branch January 15, 2025 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CMake review needed It would be great if someone could review the proposed changes. S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants