-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
edit-config button #108
base: main
Are you sure you want to change the base?
edit-config button #108
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also, CONFIG_TIMEOUT is unused, so I guess you can remove it |
@Marchand-Nicolas I have made the requested changes, including removing the unused CONFIG_TIMEOUT variable and fixing the reported error. I have tested the code, and it is working as expected. Please let me know if you need any more updates. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -64,7 +63,7 @@ const NETWORK_OPTIONS = [ | |||
|
|||
const SUPPORTED_NETWORKS = ["mainnet", "sepolia"] as const; | |||
|
|||
const addBackButton = (previousStepId: string) => { | |||
export const handleBackButton = (previousStepId: string) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get
Type '(previousStepId: string) => ActionRowBuilder<ButtonBuilder>' is not assignable to type 'ChatInputHandler | ButtonHandler | SelectMenuHandler | ModalSubmitHandler'.
Type '(previousStepId: string) => ActionRowBuilder<ButtonBuilder>' is not assignable to type 'ChatInputHandler'.
Types of parameters 'previousStepId' and 'interaction' are incompatible.
Type 'ChatInputCommandInteraction<CacheType>' is not assignable to type 'string'.ts(2322)
index.ts(77, 3): The expected type comes from property 'handler' which is declared here on type 'HandlerConfig'
discord/interactions/index.ts line 194
This PR introduces the ability to edit existing Starky role configurations through a guided flow with pre-filled values, improving user experience and reducing configuration errors.
Implementation Checklist ✅
Testing Protocol 🔍
Duplicate Config Detection
/add-config @ExistingRole
→ Verify edit button appearsEdit Flow Validation
Concurrency Test
Two users editing same config → Last valid submit wins
Notes 📌