-
Notifications
You must be signed in to change notification settings - Fork 1
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix compiler warnings related to nullability in Relationships module (#…
…505) * feat: update project with nullable reference type warnings * refactor: make method param nullable refactor: remove check, id is never null * refactor: make method param nullable, RelationshipChangeIdEntityFrameworkValueConverter refactor: remove check, id is never null * refactor: make method param nullable, RelationshipTemplateIdEntityFrameworkValueConverter refactor: remove check, id should never be null * refactor: use null-forgiving operator, it's a test for null value Ids * refactor: use null-forgiving operator, it's a test for null value Ids * refactor: assign default! to prop within the parameterless ctor refactor: suppress null warning, method is testing for possible null value * refactor: make input param nullable fix: check for null values in query * refactor: make prop nullable, BlobOptions * refactor: make imput param nullable and return empty list instead of null refactor: remove null warning suppression * refactor: make prop required, RejectRelationsipChangeRequestCommand * refactor: make prop required * refactor: make prop nullable, GetChangeQuery * refactor: make prop required, GetRelationshipQuery * refactor: make input param nullable and return [] instead of null * refactor: make prop required, GetRelationshipTemplateQuery * refactor: make prop nullable, CreateRelationshipCommand refactor: remove unnecessary using directive * refactor: make prop required, RelationshipDTO * refactor: make prop required, RelatoinshipMetadataDTO * refactor: make prop required * refactor: make prop required, CreateRelationshipTemplateResponse * refactor: make prop required, RelationshipTemplateDTO * refactor: assign null! to field in the ctor * refactor: suppress warning, field can not be null at this point * refactor: assign null with null-forgiving operator to the prop * refactor: make prop nullable * refactor: make prop nullable * refactor: make prop nullable, PersistenceOptions * refactor: remove nullability operator refactor: assign null with null-forgiving operator * refactor: make prop required * refactor: make returning type nullable * refactor: make returning type nullable, now method does what it says it does * refactor: enable method to return null * refactor: enable method to return null * refactor: suppress code warning in tests * refactor: make prop required * refactor: change prop form required to nullable * fix: change prop from required to nullable * fix: change prop from required to nullable * fix: change prop form required to nullable * refactor: make prop required * refactor: make prop required * refactor: make prop required * refactor: make prop required * fix: change prop from required to nullable * refactor: make prop required * refactor: make prop required * refactor: suppress null reference warning in RelationshipTests * Enable Mergify (#520) * ci: enable mergify * ci: remove autoupdate.yml * chore remove mergify.yaml * chore: fix nullability annotations in NumberOfBytesValidator * chore: fix nullability for Relationship recursiveley * chore: remove unused file * chore: comment ef core constructors * chore: fix nullability of Range and OptionalDateRange * chore: fix nullability for ListChangesQuery * chore: fix nullability of RangeValidator * chore: fix some compiler warnings * chore: remove unused methods * chore: fix nullability in RelationshipTests --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Timo Notheisen <[email protected]> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: Timo Notheisen <[email protected]>
- Loading branch information
1 parent
2b52cd4
commit 5a6ea7a
Showing
49 changed files
with
239 additions
and
268 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 changes: 0 additions & 21 deletions
21
Modules/Relationships/src/Relationships.Application/Extensions/ChangeHistoryExtensions.cs
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,5 +2,5 @@ | |
|
||
public class BlobOptions | ||
{ | ||
public string RootFolder { get; set; } | ||
public string? RootFolder { get; set; } | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 changes: 3 additions & 0 deletions
3
Modules/Relationships/src/Relationships.Application/Relationships.Application.csproj
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.