Skip to content

Commit

Permalink
test: remove unnecessary test for PushService.Delete
Browse files Browse the repository at this point in the history
  • Loading branch information
tnotheis committed Nov 14, 2024
1 parent 210c05b commit 70169da
Showing 1 changed file with 0 additions and 49 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
using Backbone.DevelopmentKit.Identity.ValueObjects;
using Backbone.Modules.Devices.Application.Infrastructure.Persistence.Repository;
using Backbone.Modules.Devices.Domain.Aggregates.PushNotifications;
using Backbone.Modules.Devices.Domain.Aggregates.PushNotifications.Handles;
Expand Down Expand Up @@ -64,54 +63,6 @@ public async Task Update_existing_PnsRegistration_in_repository()
.MustHaveHappenedOnceExactly();
}

[Fact]
public async Task Delete_existing_PnsRegistration()
{
// Arrange
var deviceId = CreateRandomDeviceId();
var identityAddress = CreateRandomIdentityAddress();

var pnsHandle = PnsHandle.Parse(PushNotificationPlatform.Fcm, "someValue").Value;
var pnsRegistration = new PnsRegistration(identityAddress, deviceId, pnsHandle, "someAppId", PushEnvironment.Development);

var mockPnsRegistrationsRepository = A.Fake<IPnsRegistrationsRepository>();

A.CallTo(() => mockPnsRegistrationsRepository.FindByDeviceId(deviceId, A<CancellationToken>._, A<bool>._))
.Returns(pnsRegistration);

var directPushService = CreateDirectPushService(mockPnsRegistrationsRepository);

// Act
await directPushService.DeleteRegistration(deviceId, CancellationToken.None);

// Assert
A.CallTo(() => mockPnsRegistrationsRepository.Delete(
A<List<DeviceId>>.That.Matches(e => e.FirstOrDefault() == deviceId), CancellationToken.None))
.MustHaveHappenedOnceExactly();
}

[Fact]
public async Task Trying_to_delete_non_existing_PnsRegistration_does_nothing()
{
// Arrange
var deviceId = CreateRandomDeviceId();

var mockPnsRegistrationsRepository = A.Fake<IPnsRegistrationsRepository>();

A.CallTo(() => mockPnsRegistrationsRepository.FindByDeviceId(deviceId, A<CancellationToken>._, A<bool>._))
.Returns<PnsRegistration?>(null);

var directPushService = CreateDirectPushService(mockPnsRegistrationsRepository);

// Act
await directPushService.DeleteRegistration(deviceId, CancellationToken.None);

// Assert
A.CallTo(() => mockPnsRegistrationsRepository.Delete(
A<List<DeviceId>>._, CancellationToken.None))
.MustNotHaveHappened();
}

private PushService CreateDirectPushService(IPnsRegistrationsRepository pnsRegistrationsRepository, PnsConnectorFactory? pnsConnectorFactory = null,
IIdentitiesRepository? identitiesRepository = null)
{
Expand Down

0 comments on commit 70169da

Please sign in to comment.