Use const for constant primitive variables (#568)

BuildingBlocks/test/BuildingBlocks.Infrastructure.Tests/Tests/AzureStorageAccountTests.cs

@@ -79,7 +79,7 @@ public async Task AzureSaveAsyncAndFindAsync()
     {
         var azureBlobStorage = ProvisionAzureStorageTests();
 
-        var addBlobName = "AzureSaveAsyncAndFindAsync";
+        const string addBlobName = "AzureSaveAsyncAndFindAsync";
         var addBlobContent = "AzureSaveAsyncAndFindAsync"u8.ToArray();
 
         azureBlobStorage.Add(CONTAINER_NAME, addBlobName, addBlobContent);

BuildingBlocks/test/Crypto.Tests/KeyGeneratorTests.cs

@@ -15,7 +15,7 @@ public void GenerateSymmetricKey_ShouldGenerateKeyThatCanBeUsedForSymmetricEncry
     {
         // Arrange
         var aesEncryptionHelper = AesSymmetricEncrypter.CreateWith96BitIv128BitMac();
-        var testString = "Test";
+        const string testString = "Test";
 
         // Act
         var symmetricKey = _keyGeneratorUnderTest.GenerateSymmetricKey(256);
@@ -64,7 +64,7 @@ public void DeriveSymmetricKeyWithEcdh_ShouldGenerateKeyThatCanBeUsedForSymmetri
         var privateKey = ConvertibleString.FromBase64(
             "MIHuAgEAMBAGByqGSM49AgEGBSuBBAAjBIHWMIHTAgEBBEIBAkkvXspQwTUbnqQE0PO5Xtnb9F223zF7XP0Y1NXxbaVQassO16X118JTCGOosEe3j28oVXQRbWGyEkQf6f0kv1ShgYkDgYYABAAc5lIvb4RUVQ7GJPWVNpL4VAJz0PZCbzHkTGCDvdFo4HOr/vA2AQrXOKZVtqOxQUj/ffUQhvsE8B49Sh0ZzPtRxgHx4uQSPqPlBcgqCHA4/XHs9LPbvKNYYkkPoBZy9spmtVrGktJi+M1inAlStTnxr//VC3ZAFbWS7fhW9EiGHBbeUA==");
         var aesEncryptionHelper = AesSymmetricEncrypter.CreateWith96BitIv128BitMac();
-        var testString = "Test";
+        const string testString = "Test";
 
         // Act
         var symmetricKey = _keyGeneratorUnderTest.DeriveSymmetricKeyWithEcdh(privateKey, publicKey, 256);

BuildingBlocks/test/Crypto.Tests/Tests/Implementations/Deprecated/BouncyCastle/AesEncryptionHelperTests.cs

@@ -23,7 +23,7 @@ public AesEncryptionHelperTests()
     public void Decrypt_GivesCorrectResult_IfEncryptedTextWasGeneratedByEncrypt()
     {
         // Arrange
-        var expected = "Test";
+        const string expected = "Test";
         var key = ConvertibleString.FromBase64("ZcR3a8iOzdQnC0nWHWIH6zJIwBAu2rz4EWNVtr98C/c=");
         var cipherText = _symmetricEncrypterUnderTest.Encrypt(ConvertibleString.FromUtf8(expected), key);
 
@@ -87,7 +87,7 @@ public void Decrypt_RaisesException_IfKeyHasInvalidLength(string base64Key)
     public void Encrypt_ShouldReturnDifferentResults_EvenThoughParametersAreTheSame()
     {
         // Arrange
-        var plaintext = "Test";
+        const string plaintext = "Test";
         var key = ConvertibleString.FromBase64("ZcR3a8iOzdQnC0nWHWIH6zJIwBAu2rz4EWNVtr98C/c=");
 
         // Act

Modules/Devices/test/Devices.Application.Tests/Tests/Clients/Commands/ChangeClientSecret/HandlerTests.cs

@@ -15,7 +15,7 @@ public async Task Change_client_secret()
         // Arrange
         var client = new OAuthClient("some-client-id", string.Empty, TierId.Generate(), SystemTime.UtcNow, 1);
 
-        var newClientSecret = "New-client-secret";
+        const string newClientSecret = "New-client-secret";
         var command = new ChangeClientSecretCommand(client.ClientId, newClientSecret);
 
         var oAuthClientsRepository = A.Fake<IOAuthClientsRepository>();

Modules/Devices/test/Devices.Domain.Tests/OAuthClients/OAuthClientTests.cs

@@ -12,12 +12,12 @@ public void Client_properties_are_updated_with_new_values()
     {
         // Arrange
         var oldTierId = TierId.Generate();
-        var oldMaxIdentities = 1;
+        const int oldMaxIdentities = 1;
 
         var client = new OAuthClient(string.Empty, string.Empty, oldTierId, SystemTime.UtcNow, oldMaxIdentities);
 
         var newTierId = TierId.Generate();
-        var newMaxIdentities = 2;
+        const int newMaxIdentities = 2;
 
         // Act
         client.Update(newTierId, newMaxIdentities);
@@ -32,12 +32,12 @@ public void Client_update_detects_new_values()
     {
         // Arrange
         var oldTierId = TierId.Generate();
-        var oldMaxIdentities = 1;
+        const int oldMaxIdentities = 1;
 
         var client = new OAuthClient(string.Empty, string.Empty, oldTierId, SystemTime.UtcNow, oldMaxIdentities);
 
         var newTierId = TierId.Generate();
-        var newMaxIdentities = 2;
+        const int newMaxIdentities = 2;
 
         // Act
         var hasChanges = client.Update(newTierId, newMaxIdentities);
@@ -51,7 +51,7 @@ public void Client_update_detects_old_values()
     {
         // Arrange
         var tierId = TierId.Generate();
-        var maxIdentities = 1;
+        const int maxIdentities = 1;
         var client = new OAuthClient(string.Empty, string.Empty, tierId, SystemTime.UtcNow, maxIdentities);
 
         // Act

Modules/Devices/test/Devices.Domain.Tests/Tiers/TierIdTests.cs

@@ -8,8 +8,8 @@ public class TierIdTests
     [Fact]
     public void Can_create_tier_id_with_valid_value()
     {
-        var validTierIdPrefix = "TIR";
-        var validIdLengthWithoutPrefix = 17;
+        const string validTierIdPrefix = "TIR";
+        const int validIdLengthWithoutPrefix = 17;
         var validIdValue = validTierIdPrefix + TestDataGenerator.GenerateString(validIdLengthWithoutPrefix);
 
         var tierId = TierId.Create(validIdValue);
@@ -28,7 +28,7 @@ public void Can_generate_tier_id()
     [Fact]
     public void Cannot_create_tier_id_with_invalid_id_prefix()
     {
-        var invalidTierIdPrefix = "TIE";
+        const string invalidTierIdPrefix = "TIE";
         var tierId = TierId.Create(invalidTierIdPrefix + TestDataGenerator.GenerateString(17));
 
         var isTierIdInvalid = tierId.IsFailure;

Modules/Quotas/test/Quotas.Application.Tests/Tests/Identities/IdentityCreatedIntegrationEventHandlerTests.cs

@@ -17,7 +17,7 @@ public class IdentityCreatedIntegrationEventHandlerTests
     public async void Creates_a_copy_of_the_identity_from_the_event()
     {
         // Arrange
-        var address = "some-dummy-address";
+        const string address = "some-dummy-address";
         var tierId = new TierId("TIRsomeTierId1111111");
         var tier = new Tier(tierId, "some-tier-name");
         var mockIdentitiesRepository = A.Fake<IIdentitiesRepository>();
@@ -35,10 +35,10 @@ public async void Creates_a_copy_of_the_identity_from_the_event()
     public async void Assigns_tier_quotas_to_new_identity()
     {
         // Arrange
-        var address = "some-dummy-address";
+        const string address = "some-dummy-address";
         var tierId = new TierId("TIRsomeTierId1111111");
 
-        var max = 5;
+        const int max = 5;
         var tier = new Tier(tierId, "some-tier-name");
         tier.Quotas.Add(new TierQuotaDefinition(MetricKey.NumberOfSentMessages, max, QuotaPeriod.Month));
         tier.Quotas.Add(new TierQuotaDefinition(MetricKey.NumberOfSentMessages, max, QuotaPeriod.Week));

Modules/Quotas/test/Quotas.Application.Tests/Tests/Quotas/CreateQuotaForTier/HandlerTests.cs

@@ -30,8 +30,8 @@ public async Task Creates_quota_for_tier()
     {
         // Arrange
         var tierId = new TierId("TIRsomeTierId1111111");
-        var max = 5;
-        var period = QuotaPeriod.Month;
+        const int max = 5;
+        const QuotaPeriod period = QuotaPeriod.Month;
         var metricKey = MetricKey.NumberOfSentMessages.Value;
         var command = new CreateQuotaForTierCommand(tierId, metricKey, max, period);
         var tier = new Tier(tierId, "some-tier-name");

Modules/Quotas/test/Quotas.Application.Tests/Tests/Quotas/DeleteIndividualQuota/HandlerTests.cs

@@ -83,7 +83,7 @@ public void Fails_to_delete_individual_quota_for_inexistent_identity()
     public void Fails_to_delete_individual_quota_when_providing_an_inexistent_quota_id()
     {
         // Arrange
-        var identityAddress = "some-identity-address";
+        const string identityAddress = "some-identity-address";
         var identity = new Identity("some-identity-address", new TierId("SomeTierId"));
         var command = new DeleteQuotaForIdentityCommand(identityAddress, "QUOsomequotaid111111");
         var identitiesRepository = A.Fake<IIdentitiesRepository>();

Modules/Quotas/test/Quotas.Application.Tests/Tests/Tiers/GetTierById/HandlerTests.cs

@@ -15,12 +15,12 @@ public async void Gets_tier_by_id_one_quota()
     {
         // Arrange
         var tierId = new TierId("SomeTierId");
-        var tierName = "some-tier-name";
+        const string tierName = "some-tier-name";
         var tier = new Tier(tierId, tierName);
 
         var metricKey = MetricKey.NumberOfSentMessages;
-        var max = 5;
-        var period = QuotaPeriod.Month;
+        const int max = 5;
+        const QuotaPeriod period = QuotaPeriod.Month;
         tier.CreateQuota(metricKey, max, period);
 
         var stubTiersRepository = new FindTiersStubRepository(tier);
@@ -45,7 +45,7 @@ public async void Gets_tier_by_id_multiple_quotas()
     {
         // Arrange
         var tierId = new TierId("SomeTierId");
-        var tierName = "some-tier-name";
+        const string tierName = "some-tier-name";
         var tier = new Tier(tierId, tierName);
 
         var metricWithTwoQuotas = new Metric(MetricKey.NumberOfSentMessages, "Number Of Sent Messages");

Modules/Quotas/test/Quotas.Application.Tests/Tests/Tiers/TierCreatedIntegrationEventHandlerTests.cs

@@ -14,7 +14,7 @@ public async void Creates_tier_after_consuming_integration_event()
     {
         // Arrange
         var id = new TierId("TIRFxoL0U24aUqZDSAWc");
-        var name = "Basic";
+        const string name = "Basic";
         var mockTierRepository = new AddMockTiersRepository();
         var handler = CreateHandler(mockTierRepository);
 

Modules/Quotas/test/Quotas.Domain.Tests/IndividualQuotaTests.cs

@@ -12,8 +12,8 @@ public void Creates_individual_quota_with_valid_properties()
     {
         // Arrange
         var metricKey = MetricKey.NumberOfSentMessages;
-        var max = 10;
-        var period = QuotaPeriod.Month;
+        const int max = 10;
+        const QuotaPeriod period = QuotaPeriod.Month;
 
         // Act
         var individualQuota = new IndividualQuota(metricKey, max, period, "applyTo");

Modules/Quotas/test/Quotas.Domain.Tests/TierQuotaTests.cs

@@ -13,9 +13,9 @@ public class TierQuotaTests
     public void Can_create_tier_quota_with_valid_properties()
     {
         // Arrange
-        var max = 5;
+        const int max = 5;
         var metricKey = MetricKey.NumberOfSentMessages;
-        var period = QuotaPeriod.Month;
+        const QuotaPeriod period = QuotaPeriod.Month;
         var tierQuotaDefinition = new TierQuotaDefinition(metricKey, max, period);
         var applyTo = TestDataGenerator.CreateRandomIdentityAddress();