Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Abl 490 limit the maximum number of message recipients #1027

Closed
wants to merge 10 commits into from
Closed

Abl 490 limit the maximum number of message recipients #1027

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
3d91752
feat: added MaxNumberOfMessageRecipients
devx247 Jan 20, 2025
81bdb9b
fix: integration-test appsettings
devx247 Jan 20, 2025
23a5e08
Merge branch 'main' into ABL-490-limit-the-maximum-number-of-message-…
mergify[bot] Jan 20, 2025
0703071
Merge branch 'main' into ABL-490-limit-the-maximum-number-of-message-…
devx247 Jan 20, 2025
8005a25
Merge remote-tracking branch 'origin/ABL-490-limit-the-maximum-number…
devx247 Jan 20, 2025
afd929e
fix: updated Validator
devx247 Jan 20, 2025
200125a
chore: removed custom validation name
devx247 Jan 20, 2025
89b7b91
Merge branch 'main' into ABL-490-limit-the-maximum-number-of-message-…
mergify[bot] Jan 21, 2025
f4c1f18
Merge branch 'main' into ABL-490-limit-the-maximum-number-of-message-…
mergify[bot] Jan 22, 2025
2bb5fbe
Merge branch 'main' into ABL-490-limit-the-maximum-number-of-message-…
mergify[bot] Jan 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .ci/appsettings.override.postgres.docker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@
},
"Messages": {
"Application": {
"DidDomainName": "localhost"
"DidDomainName": "localhost",
"MaxNumberOfMessageRecipients": 5
},
"Infrastructure": {
"SqlDatabase": {
Expand Down
3 changes: 2 additions & 1 deletion .ci/appsettings.override.postgres.local.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@
},
"Messages": {
"Application": {
"DidDomainName": "localhost"
"DidDomainName": "localhost",
"MaxNumberOfMessageRecipients": 5
},
"Infrastructure": {
"SqlDatabase": {
Expand Down
3 changes: 2 additions & 1 deletion .ci/appsettings.override.sqlserver.docker.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@
},
"Messages": {
"Application": {
"DidDomainName": "localhost"
"DidDomainName": "localhost",
"MaxNumberOfMessageRecipients": 5
},
"Infrastructure": {
"SqlDatabase": {
Expand Down
3 changes: 2 additions & 1 deletion .ci/appsettings.override.sqlserver.local.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,8 @@
},
"Messages": {
"Application": {
"DidDomainName": "localhost"
"DidDomainName": "localhost",
"MaxNumberOfMessageRecipients": 5
},
"Infrastructure": {
"SqlDatabase": {
Expand Down
3 changes: 2 additions & 1 deletion Applications/ConsumerApi/src/appsettings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@
"Pagination": {
"DefaultPageSize": 50,
"MaxPageSize": 200
}
},
"MaxNumberOfMessageRecipients": 1
},
"Infrastructure": {
"SqlDatabase": {
Expand Down
3 changes: 2 additions & 1 deletion ...ations/ConsumerApi/test/ConsumerApi.Tests.Integration/api.appsettings.local.override.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,8 @@
},
"Messages": {
"Application": {
"DidDomainName": "localhost"
"DidDomainName": "localhost",
"MaxNumberOfMessageRecipients": 5
},
"Infrastructure": {
"SqlDatabase": {
Expand Down
3 changes: 3 additions & 0 deletions Modules/Messages/src/Messages.Application/ApplicationOptions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ public class ApplicationOptions
[MinLength(3)]
[MaxLength(45)]
public string DidDomainName { get; set; } = null!;

[Required]
public int MaxNumberOfMessageRecipients { get; set; }
}

public class PaginationOptions
Expand Down
6 changes: 4 additions & 2 deletions Modules/Messages/src/Messages.Application/Messages/Commands/SendMessage/Validator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,13 @@
using Backbone.Modules.Messages.Domain.Ids;
using Backbone.Tooling.Extensions;
using FluentValidation;
using Microsoft.Extensions.Options;

namespace Backbone.Modules.Messages.Application.Messages.Commands.SendMessage;

public class Validator : AbstractValidator<SendMessageCommand>
{
public Validator()
public Validator(IOptions<ApplicationOptions> options)
{
RuleFor(m => m.Recipients)
.DetailedNotNull()
Expand All @@ -21,7 +22,8 @@ public Validator()
.SetValidator(new SendMessageCommandRecipientInformationValidator()));

RuleFor(m => m.Recipients.Count)
.InclusiveBetween(1, 50).WithErrorCode(GenericApplicationErrors.Validation.InvalidPropertyValue().Code);
.LessThanOrEqualTo(options.Value.MaxNumberOfMessageRecipients)
.WithErrorCode(GenericApplicationErrors.Validation.InvalidPropertyValue().Code);

RuleFor(m => m.Body).DetailedNotNull().NumberOfBytes(1, 10.Mebibytes());

Expand Down
Loading