Admin CLI for sending announcements to all identities

[ghost]

Readiness checklist

• I added/updated unit tests.
• I added/updated integration tests.
• I ensured that the PR title is good enough for the changelog.
• I labeled the PR.

[tnotheis]

This shouldn't be necessary. As far as I know, appsettings.json files are copied by default. At least that's how it works in the other projects (e.g. ConsumerApi)

[ghost]

I'll check that

[tnotheis]

You should add the following lines (it's done like this in all the other application .csproj's):

    <Target Name="PreBuild" BeforeTargets="Build" Condition="$(Configuration) == Debug">
        <Delete Files="$(ProjectDir)appsettings.override.json" />
        <Copy SourceFiles="..\..\..\..\appsettings.override.json" DestinationFolder="$(ProjectDir)" UseHardlinksIfPossible="true" />
    </Target>

And I just noticed that I forgot one major thing: since so far the Admin CLI only used two parameters (DB provider and DB connection string), I didn't feel the need to add the full configuration stuff). But now that we need a lot more than that, we should add configuration as we do it in the other projects, like in the ConsumerApi. See

backbone/Applications/ConsumerApi/src/Program.cs

Lines 219 to 236 in 019ea5b

	static void LoadConfiguration(WebApplicationBuilder webApplicationBuilder, string[] strings)
	{
	webApplicationBuilder.Configuration.Sources.Clear();
	var env = webApplicationBuilder.Environment;
	webApplicationBuilder.Configuration
	.AddJsonFile("appsettings.json", optional: true, reloadOnChange: false)
	.AddJsonFile($"appsettings.{env.EnvironmentName}.json", optional: true, reloadOnChange: false)
	.AddJsonFile("appsettings.override.json", optional: true, reloadOnChange: true);
	if (env.IsDevelopment())
	{
	var appAssembly = Assembly.Load(new AssemblyName(env.ApplicationName));
	webApplicationBuilder.Configuration.AddUserSecrets(appAssembly, optional: true);
	}
	webApplicationBuilder.Configuration.AddEnvironmentVariables();
	webApplicationBuilder.Configuration.AddCommandLine(strings);

for an example.

[ghost]

I'll add that

[tnotheis]

I think it would be good to add a list of possible values to the description of this option.

[ghost]

I'll add that suggestion

[tnotheis]

Didn't we agree on removing the default value?

[ghost]

You're right. Will be removed.

[tnotheis]

I don't know if I'm missing something, but to me it looks as if with this line you always return null.

[ghost]

Yeah looks little wired. That term is not required and gets removed (input == null ||

[tnotheis]

It's not necessary to do this check. This is already done by the MediatR command validator.

[ghost]

I see no good reson why not do an early exit, before the MeditR validator gets called, but ok I can remove that check.

[tnotheis]

I usually don't like duplicating the validation logic. More places where you have to remember to change things if you want to.
But yeah, on the other hand I'm also a friend of early returns. Debatable. :)

[tnotheis]

Adding these settings into appsettings.json is not good. The appsettings.json file is only meant for default values that make sense in any environment. But a rabbitmq event bus for example doesn't fulfill this criteria.

[ghost]

I'll adopt it as it's done in AdminApi

[tnotheis]

This should be replaced with what I wrote in one of my first comments.

[ghost]

Ok

[tnotheis]

This shouldn't be necessary.

[ghost]

Yeah, and BTW it doesn't work :-(

[tnotheis]

Let's see if it works once you're done with the other configuration related changes

[tnotheis]

Suggested change

	public class DevicesCliConfiguration
	public class DevicesConfiguration

[ghost]

I can rename it.