Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Admin API for sending announcements to specific identities #1034

Merged
merged 65 commits into from
Jan 28, 2025
Merged

Admin API for sending announcements to specific identities #1034

merged 65 commits into from
Jan 28, 2025

Conversation

tnotheis
Copy link
Member

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

devx247 and others added 30 commits January 8, 2025 14:07
@devx247
feat: added optional property recipients and validation rule
5435a16 
added some bruno http request files
@devx247
fix: declared the property Recipients as nullable
60208d0
@devx247
fix: validation rule of Recipients
ccc0caf
@devx247
fix: validation of property Recipients
25d9bc8
@devx247
feat: added AnnouncementRecipient + Migration + Handler update
095dd29
@devx247
feat: added AnnouncementRecipient Migration
244b257
@devx247
feat: added announcement-recipients, updated outgoing/incoming domain…
c2de326 
…-event, updated push-service
@devx247
feat: return recipients in admin-api on get request
4cdda3b
@devx247
feat: added Announcement Recipient IdentityDeleter
73738a9
@devx247
Merge branch 'main' into ABL-174-admin-api-send-announcements-to-spec…
695ca99 
…ify-identities
@mergify
Merge branch 'main' into ABL-174-admin-api-send-announcements-to-spec…
2a641b5 
…ify-identities
@mergify
Merge branch 'main' into ABL-174-admin-api-send-announcements-to-spec…
c10da3f 
…ify-identities
@devx247
chore: removed pubspec.lock
42269c3
@devx247
Merge remote-tracking branch 'origin/ABL-174-admin-api-send-announcem…
003e408 
…ents-to-specify-identities' into ABL-174-admin-api-send-announcements-to-specify-identities

# Conflicts:
#	Applications/AdminUi/apps/admin_ui/pubspec.lock
@devx247
fix: fixed AnnouncementRecipient + PushService usage per PnsHandle
9277fcb
@devx247
test: added CreateAnnouncement Handler Tests
f5261ba
@devx247
test: added AnnouncementRecipient Anonymize IdentityDeleter Tests
9096229
@devx247
test: added AnonymizeRecipient tests
6e170dc
@tnotheis
Merge branch 'main' into ABL-174-admin-api-send-announcements-to-spec…
9328f7f 
…ify-identities
@devx247
Merge branch 'main' into ABL-174-admin-api-send-announcements-to-spec…
014dd0a 
…ify-identities
@devx247
fix: updated docker file
81f9fc6
@devx247
fix: updated docker-file
9b8f0f8
@devx247
chore: added debug-logging
9af11c3
@devx247
chore: added some debug statement
31d33a7
@devx247
chore: debug - check database-migrator logs
dda86bc
@devx247
chore: debug - fixed the check database-migrator-test log cmd
b46d207
@devx247
chore: added new migration as error seen in logs regarding Announceme…
c9c4e18 
…ntsDbContext
@devx247
fix: added announcement-recipient migration for sqlserver + postgres db
2df11a5
@devx247
fix: another attempt to get the database-migrator-test logs
5829632
@devx247
chore: try to log exiting ci-seed-database-1 container
b48c27c
@tnotheis tnotheis added the enhancement New feature or request label Jan 27, 2025
@tnotheis tnotheis self-assigned this Jan 27, 2025
mergify bot and others added 21 commits January 27, 2025 08:11
@mergify
Merge branch 'main' into ABL-174-admin-api-send-announcements-to-spec…
0f7ccd0 
…ify-identities
@tnotheis
chore: cleanup
9f18a45
@tnotheis
fix: remove didDomainName from appsettings.json files and add it to a…
2455ec7 
…ppsettings.override.json files
@tnotheis
feat: delete recipients instead of anonymizing them
af3453f
@mergify
Merge branch 'main' into ABL-174-admin-api-send-announcements-to-spec…
d62ea22 
…ify-identities
@tnotheis
refactor: simplify CreateAnnouncement Handler
1889c9c
@tnotheis
chore: add FromBody attribute
6ab554a
@tnotheis
refactor: simplify application logic by adding a default value to the…
2b6ce10 
… `Recipients` property of the CreateAnnouncementCommand
@tnotheis
fix: don't catch and rethrow exceptions in SseServerClient
2f7a92a
@tnotheis
refactor: simplify validation
97bd30a
@tnotheis
fix: fix migration errors
7d4f08a
@tnotheis
fix: return simple string instead of an object in AnnouncementDTO.cs
088ad5f
@tnotheis
chore: delete redundant tests
72192c9
@tnotheis
chore: delete unused repository method
66169bc
@tnotheis
chore: don't unclude navigation properties when deleting recipients
0c49df8
@tnotheis
chore: cleanup
8b7a410
@tnotheis
refactor: move extension method to correct place
7992d91
@tnotheis
refactor: simplify AnnouncementCreatedDomainEventHandler
25d9748
@tnotheis
chore: restore original order of members of PushService
e04ee3d
@tnotheis
refactor: filter for distinct handles in PushService instead of in th…
2e69771 
…e repository
@tnotheis
test: fix invalidId tests
78d6d91
jkoenig134
jkoenig134 previously approved these changes Jan 28, 2025
View reviewed changes
@tnotheis tnotheis merged commit cbdb115 into main Jan 28, 2025
20 of 22 checks passed
@tnotheis tnotheis deleted the ABL-174-admin-api-send-announcements-to-specify-identities branch January 28, 2025 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoenig134 jkoenig134 jkoenig134 approved these changes

Assignees

@tnotheis tnotheis

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tnotheis @jkoenig134 @devx247