Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compiler warnings related to nullability in Files module #509

Merged
merged 20 commits into from
Feb 9, 2024

Conversation

MH321Productions
Copy link
Contributor

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration tests.
  • I ensured that the PR title is good enough for the changelog.
  • I labeled the PR.

@MH321Productions MH321Productions added the refactoring Refactoring of code label Jan 29, 2024
@MH321Productions MH321Productions changed the title Consumer API: Fix nullability issues Consumer API: Fix Files nullability issues Jan 30, 2024
@MH321Productions MH321Productions self-assigned this Jan 30, 2024
Copy link

coderabbitai bot commented Feb 5, 2024

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository from git and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@tnotheis tnotheis changed the title Consumer API: Fix Files nullability issues Fix compiler warnings related to nullability in Files module Feb 9, 2024
@tnotheis
Copy link
Member

tnotheis commented Feb 9, 2024

@MH321Productions I changed the title so it is consistent with the other PRs. In case of a refactoring, the prefix ("Consmumer API"/"Admin UI") isn't important, as they don't show up in the release notes anyway.

tnotheis
tnotheis previously approved these changes Feb 9, 2024
@tnotheis tnotheis enabled auto-merge (squash) February 9, 2024 12:01
@tnotheis tnotheis disabled auto-merge February 9, 2024 12:02
@tnotheis tnotheis enabled auto-merge (squash) February 9, 2024 12:04
@tnotheis tnotheis requested a review from NikolaVetnic February 9, 2024 12:54
@tnotheis tnotheis merged commit 2baebb6 into main Feb 9, 2024
13 checks passed
@tnotheis tnotheis deleted the fix-files-nullability-issues branch February 9, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring of code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants