Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consumer API: Starting multiple sync runs in parallel leads to an internal server error #512

Merged
merged 7 commits into from
Feb 6, 2024
Merged

Consumer API: Starting multiple sync runs in parallel leads to an internal server error #512

Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1d415bf
fix: change exception reason to UniqueKeyViolation instead of Duplica…
NikolaDmitrasinovic Jan 31, 2024
51cd816
fix: return DuplicateIndex and UniqueKeyViolation exception reason
NikolaDmitrasinovic Jan 31, 2024
14b589a
refactor: merge IF cases
NikolaDmitrasinovic Jan 31, 2024
54c074a
Merge main into fix-multiple-sync-runs-error
github-actions[bot] Feb 5, 2024
52c437c
Merge main into fix-multiple-sync-runs-error
github-actions[bot] Feb 5, 2024
9a9080f
ci: trigger pipelines
NikolaDmitrasinovic Feb 6, 2024
4038859
Merge branch 'fix-multiple-sync-runs-error' of https://github.com/nms…
NikolaDmitrasinovic Feb 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ...Synchronization/src/Synchronization.Application/SyncRuns/Commands/StartSyncRun/Handler.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,7 +133,7 @@ private async Task<SyncRun> CreateNewSyncRun(IEnumerable<ExternalEvent> events)
}
catch (DbUpdateException ex)
{
if (ex.HasReason(DbUpdateExceptionReason.DuplicateIndex))
if (ex.HasReason(DbUpdateExceptionReason.DuplicateIndex) || ex.HasReason(DbUpdateExceptionReason.UniqueKeyViolation))
throw new OperationFailedException(ApplicationErrors.SyncRuns.CannotStartSyncRunWhenAnotherSyncRunIsRunning());

throw;
Expand Down
Loading