Admin UI: tier quota definition is not deleted from the database after removing it from a tier

[NikolaVetnic]

Readiness checklist

• I added/updated unit tests.
• I added/updated integration tests.
• I ensured that the PR title is good enough for the changelog.
• I labeled the PR.

Description

Prior to fixing it the attempt at deleting the tier quota definition in the Admin UI would imply orphan it, i.e. set its TierId column value to null, making it in effect "orphaned" (not connected to any Tier entity). Database operation trigger is introduced that is activated after updating tier quota definition and which deletes the said definition should it turn out to be orphaned.

[coderabbitai]

Important

Auto Review Skipped

Auto reviews are disabled on this repository.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository.

To trigger a single review, invoke the @coderabbitai review command.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

• X
• Mastodon
• Reddit
• LinkedIn

---

Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>.
  • Generate unit-tests for this file.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit tests for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai generate interesting stats about this repository from git and render them as a table.
  • @coderabbitai show all the console.log statements in this repository.
  • @coderabbitai read src/utils.ts and generate unit tests.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• The JSON schema for the configuration file is available here.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

[tnotheis]

@NikolaVetnic The title of the PR is a bit messed up.

"Neither [...] nor [...] are not merged [...]"

• "Neither" and "are not" is a double negation.
• I don't see how "merged" would make sense in this context

[tnotheis]

Did you try to write a test for this? With the db contexts of the FakeDbContextFactory this should be possible, I think.

So:

1. Create fake db contexts
2. Use the actContext to create a repository
3. Use the repository to add a Tier with a quota
4. Delete the quota from the Tier
5. Use the repository to delete the Tier
6. Use the assertionContext to check whether the TierQuotaDefinition was deleted as well.

[tnotheis]

Question: did you do a manual test?

[NikolaVetnic]

Question: did you do a manual test?

Literally the first thing I did :) I'll do it once again just to be on the safe side.
UPDATE: Tested, works as expected.